AIX(,HPUX): jsval.h JSVAL_ALIGNMENT definition for AIX / skip C++ enum usage

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: andrew, Assigned: andrew)

Tracking

Trunk
PowerPC
AIX
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Created attachment 499333 [details] [diff] [review]
Define JSVAL_ALIGNMENT under xlc/xlC

The IBM XL C/C++ compile supports __attribute__((aligned (8))) just like gcc.
Attachment #499333 - Flags: review?(mrbkap)
(Assignee)

Comment 1

8 years ago
Hmm.. modifying patch to also skip the enum typedef in C++ mode because xlC does not support unsigned integer enum constants.
Summary: AIX: jsval.h JSVAL_ALIGNMENT definition for AIX → AIX: jsval.h JSVAL_ALIGNMENT definition for AIX / skip C++ enum usage
(Assignee)

Comment 2

8 years ago
Created attachment 499335 [details] [diff] [review]
Define JSVAL_ALIGNMENT and skip enum type definition
Attachment #499333 - Attachment is obsolete: true
Attachment #499335 - Flags: review?(mrbkap)
Attachment #499333 - Flags: review?(mrbkap)
(Assignee)

Updated

8 years ago
Attachment #499335 - Flags: approval2.0?
(Assignee)

Comment 3

8 years ago
Created attachment 499558 [details] [diff] [review]
Define JSVAL_ALIGNMENT and skip enum type definition

Added HP cc/aCC which also need to blank out JSVAL_ALIGNMENT.
Attachment #499335 - Attachment is obsolete: true
Attachment #499558 - Flags: review?(mrbkap)
Attachment #499558 - Flags: approval2.0?
Attachment #499335 - Flags: review?(mrbkap)
Attachment #499335 - Flags: approval2.0?
(Assignee)

Updated

8 years ago
Summary: AIX: jsval.h JSVAL_ALIGNMENT definition for AIX / skip C++ enum usage → AIX(,HPUX): jsval.h JSVAL_ALIGNMENT definition for AIX / skip C++ enum usage
Comment on attachment 499558 [details] [diff] [review]
Define JSVAL_ALIGNMENT and skip enum type definition

r+ before a?, please

(we'll probably take these after we ship)
Attachment #499558 - Flags: approval2.0?
Attachment #499558 - Flags: review?(mrbkap) → review+
Assignee: general → andrew
http://hg.mozilla.org/mozilla-central/rev/e8dda9a82da7
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.