Closed Bug 621018 Opened 9 years ago Closed 9 years ago

Some browser chrome tests in browser/base/content try to load AMO content

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b9

People

(Reporter: mak, Assigned: philor)

Details

Attachments

(1 file, 1 obsolete file)

http://mxr.mozilla.org/mozilla-central/search?string=about:addons&find=browser_

these tests should define extensions.webservice.discoverURL to something local if they really need to access about:addons

No network access please!
The toolkit one is fine, because of http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/browser/head.js#42

The fun part is that whether or not other ones are fine depends on the order the tests run in, since that clears the other two prefs it sets, but not that one.
Attached patch Fix v.1 (obsolete) — Splinter Review
A little copy, a little paste...
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #499690 - Flags: review?(dtownsend)
Comment on attachment 499690 [details] [diff] [review]
Fix v.1

I like it and I'd like to say yes, but really if we're just setting the pref and wanting it to stay set for hte lifetime of the tests then we should just do so in automation.py.in. I probably should have put it there in the first place.
Attachment #499690 - Flags: review?(dtownsend) → review-
Attached patch Fix v.2Splinter Review
Sigh. I thought I remembered seeing where we set some server prefs, but I didn't see it in runtests.py, so I just applied the power of my clipboard instead of my mind.
Attachment #499690 - Attachment is obsolete: true
Attachment #499691 - Flags: review?(dtownsend)
Comment on attachment 499691 [details] [diff] [review]
Fix v.2

browser_discover.js depends on PREF_DISCOVERURL being defined so define it there but otherwise this looks good.
Attachment #499691 - Flags: review?(dtownsend) → review+
http://hg.mozilla.org/mozilla-central/rev/2d34079b62fa
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b9
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.