Closed Bug 621021 Opened 9 years ago Closed 9 years ago

AIX: Makefile.in patch to suppress 2 superfluous xlC warnings

Categories

(Core :: JavaScript Engine, defect)

PowerPC
AIX
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: andrew, Assigned: andrew)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

This patch to Makefile.in suppresses two xlC warnings that are superfluous since the engine is specifically using the two features. They are:

- offsetof() on null non-POD types
- static data members in anonymous unions

These warnings spew out multiple times for every file, so this will shut them up.
Attachment #499352 - Flags: review?(mrbkap)
Attachment #499352 - Flags: approval2.0?
Updated patch to silence the same warnings on HP-UX as well. Added #ifndef GNU_CC to ensure that the native compiler flags are only added when non-GNU compilers are used.
Attachment #499352 - Attachment is obsolete: true
Attachment #499527 - Flags: review?(mrbkap)
Attachment #499527 - Flags: approval2.0?
Attachment #499352 - Flags: review?(mrbkap)
Attachment #499352 - Flags: approval2.0?
Comment on attachment 499527 [details] [diff] [review]
Silence warnings in AIX and HP-UX for non-GNU compilers

r+ before a?, please

(we'll probably take these after we ship)
Attachment #499527 - Flags: approval2.0?
Attachment #499527 - Flags: review?(mrbkap) → review+
Assignee: general → andrew
http://hg.mozilla.org/mozilla-central/rev/33a3ffc64867
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.