621024 - nsILoginManager::addLogin: Can't add a login with a null or empty password

Status: RESOLVED DUPLICATE of bug 609380

(Firefox :: Sync, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

Not really UI but also not server. Feel free to move where it belongs.

Fehler: [Exception... "'Can't add a login with a null or empty password.' when calling method: [nsILoginManager::addLogin]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: resource://services-sync/engines/passwords.js :: PasswordStore__create :: line 192"  data: no]
Quelldatei: resource://services-sync/engines/passwords.js
Zeile: 192

This is what I currently get when I try to sync one of my machines.
(it's displayed as an unknown error in the UI.

While I'm not aware of the fact that I would have an empty password in my password store it shouldn't break sync completely anyways.

Comment 1

[Philipp von Weitershausen [:philikon]]

Seems related to bug 619427

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Probably similar reason but other location?

Anyway, I've deleted the entries with empty passwords in my main Firefox and sync to the other one works again.
I have no idea how those entries got added over the last years but apparently it was possible. nsLoginManager doesn't allow that anymore so it fails.
The problem is that the whole sync seems to be cancelled what shouldn't be the case.
Just try .. catch it?

Comment 4

[Richard Newman [:rnewman]]

Had another user hit this tonight; his profile had lots of empty passwords. Would be nice to get a simple try/catch fix out there...

Comment 5

[Richard Newman [:rnewman]]

Oh, and don't upload records with null or empty values.

Comment 7

[r.goff]

For those trying to work around this, the server data has to be overwritten with good data, not merged.

Comment 8

[Philipp von Weitershausen [:philikon]]

I morphed bug 609380 into dealing properly with broken password records.

Comment 9

[Jeremy (JedMeister)]

I'm experiencing this or a similar bug (ie "Unknown error"). Not sure what I need to do to make my bug report more useful? I haven't had a chance to check on other computers but I am experiencing this on Ubuntu 10.04 running Firefox 3.6.13

Comment 10

[Philipp von Weitershausen [:philikon]]

(In reply to comment #9)
> I'm experiencing this or a similar bug (ie "Unknown error").

That could be anything so I wouldn't jump to conclusions here about similarity.

> Not sure what I need to do to make my bug report more useful?

Please always file a *new* bug. Go to about:sync-log in your browser, save it as a file and attach it to that bug. Thanks!