Closed Bug 621026 Opened 9 years ago Closed 9 years ago

AIX(,SOLARIS,HPUX): jstypes.h compile failure due to lack of JS_64BIT definition

Categories

(Core :: JavaScript Engine, defect)

PowerPC
AIX
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: andrew, Assigned: andrew)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

This patch adds a JS_64BIT definition for Sun Studio (sparcv9), IBM XL C/C++, and HPUX aCC so the compile does not fail here:

# error "Implement me"
Attachment #499359 - Flags: review?(mrbkap)
Attachment #499359 - Flags: approval2.0?
Adds missing __HP_cc to cover the C compiler as well.
Attachment #499359 - Attachment is obsolete: true
Attachment #499561 - Flags: review?(mrbkap)
Attachment #499561 - Flags: approval2.0?
Attachment #499359 - Flags: review?(mrbkap)
Attachment #499359 - Flags: approval2.0?
Comment on attachment 499561 [details] [diff] [review]
Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

r+ before a?, please

(we'll probably take these after we ship)
Attachment #499561 - Flags: approval2.0?
Comment on attachment 499561 [details] [diff] [review]
Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

I'm kind of surprised this isn't a configure check.
Attachment #499561 - Flags: review?(mrbkap) → review+
Assignee: general → andrew
http://hg.mozilla.org/mozilla-central/rev/68d671e5abc3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.