621026 - AIX(,SOLARIS,HPUX): jstypes.h compile failure due to lack of JS_64BIT definition

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew Paprocki]

Attachment: Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

This patch adds a JS_64BIT definition for Sun Studio (sparcv9), IBM XL C/C++, and HPUX aCC so the compile does not fail here:

# error "Implement me"

Comment 1

[Andrew Paprocki]

Attachment: Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

Adds missing __HP_cc to cover the C compiler as well.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 499561 [details] [diff] [review]
Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

r+ before a?, please

(we'll probably take these after we ship)

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 499561 [details] [diff] [review]
Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

I'm kind of surprised this isn't a configure check.

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/tracemonkey/rev/68d671e5abc3

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/68d671e5abc3