AIX(,SOLARIS,HPUX): jstypes.h compile failure due to lack of JS_64BIT definition

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Andrew Paprocki, Assigned: Andrew Paprocki)

Tracking

Trunk
PowerPC
AIX
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 499359 [details] [diff] [review]
Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

This patch adds a JS_64BIT definition for Sun Studio (sparcv9), IBM XL C/C++, and HPUX aCC so the compile does not fail here:

# error "Implement me"
Attachment #499359 - Flags: review?(mrbkap)
(Assignee)

Updated

7 years ago
Attachment #499359 - Flags: approval2.0?
(Assignee)

Comment 1

7 years ago
Created attachment 499561 [details] [diff] [review]
Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

Adds missing __HP_cc to cover the C compiler as well.
Attachment #499359 - Attachment is obsolete: true
Attachment #499561 - Flags: review?(mrbkap)
Attachment #499561 - Flags: approval2.0?
Attachment #499359 - Flags: review?(mrbkap)
Attachment #499359 - Flags: approval2.0?
Comment on attachment 499561 [details] [diff] [review]
Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

r+ before a?, please

(we'll probably take these after we ship)
Attachment #499561 - Flags: approval2.0?
Comment on attachment 499561 [details] [diff] [review]
Define JS_64BIT properly in Sun Studio, IBM XL C/C++, and HPUX aCC

I'm kind of surprised this isn't a configure check.
Attachment #499561 - Flags: review?(mrbkap) → review+
Assignee: general → andrew
http://hg.mozilla.org/tracemonkey/rev/68d671e5abc3
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/68d671e5abc3
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.