AIX: jsstr.cpp #pragma pack options not valid for OS

RESOLVED FIXED in mozilla6

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Andrew Paprocki, Assigned: Andrew Paprocki)

Tracking

Trunk
mozilla6
PowerPC
AIX
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 499365 [details] [diff] [review]
Fix #ifdefs around pragmas and alignment

The #pragma packing going on in jsstr.cpp spews on AIX because the default gcc case is not valid inside xlC. This patch modifies the #ifdef logic so that xlC is supported. Also, the __attribute__ ((aligned (8))) usage is used because xlC supports it.

"jsstr.cpp", line 3180.14: 1540-1400 (W) The incorrect pragma is ignored.
"jsstr.cpp", line 3180.14: 1540-1404 (W) The parameter "push" specified for "pragma pack" is not valid. The pragma is ignored.
"jsstr.cpp", line 3192.9: 1540-1421 (W) Attempting to pop an empty "pragma pack" stack. The current pack setting may be invalid.
"jsstr.cpp", line 3240.14: 1540-1400 (W) The incorrect pragma is ignored.
"jsstr.cpp", line 3240.14: 1540-1404 (W) The parameter "push" specified for "pragma pack" is not valid. The pragma is ignored.
"jsstr.cpp", line 3252.9: 1540-1421 (W) Attempting to pop an empty "pragma pack" stack. The current pack setting may be invalid.
"jsstr.cpp", line 3276.14: 1540-1400 (W) The incorrect pragma is ignored.
"jsstr.cpp", line 3276.14: 1540-1404 (W) The parameter "push" specified for "pragma pack" is not valid. The pragma is ignored.
"jsstr.cpp", line 3304.9: 1540-1421 (W) Attempting to pop an empty "pragma pack" stack. The current pack setting may be invalid.
Attachment #499365 - Flags: review?(mrbkap)
(Assignee)

Updated

7 years ago
Attachment #499365 - Flags: approval2.0?
Comment on attachment 499365 [details] [diff] [review]
Fix #ifdefs around pragmas and alignment

r+ before a?, please

(we'll probably take these after we ship)
Attachment #499365 - Flags: approval2.0?
Comment on attachment 499365 [details] [diff] [review]
Fix #ifdefs around pragmas and alignment

Does Windows need the #pragma pack stuff here?
Attachment #499365 - Flags: review?(mrbkap)
(Assignee)

Comment 3

6 years ago
Created attachment 525707 [details] [diff] [review]
Fix #ifdefs around pragmas and alignment

I cleaned up the patch. I realized all I needed to do was add the HP aCC case, IBM xlC support, and exclude -Dlint from the default case. GCC, Windows, anything else will continue to flow through to the existing default. I added a comment explaining everything so it won't be confusing later.
Attachment #499365 - Attachment is obsolete: true
Attachment #525707 - Flags: review?(mrbkap)

Updated

6 years ago
Attachment #525707 - Flags: review?(mrbkap) → review+
Oh, and thanks for adding that comment, it was really useful.

Updated

6 years ago
Assignee: general → andrew
Keywords: checkin-needed
This patch doesn't seem to apply anymore on a recent trunk.
Andrew, could you update it so I will push it for you.
(Assignee)

Comment 6

6 years ago
Created attachment 527070 [details] [diff] [review]
Fix #ifdefs around pragmas and alignment

Updated r+ patch to apply cleanly to current m-c.
Attachment #525707 - Attachment is obsolete: true
Attachment #527070 - Flags: review?(mrbkap)

Updated

6 years ago
Attachment #527070 - Flags: review?(mrbkap) → review+
Fixed in cedar. The patch will be landed in mozilla-central with the next cedar sync (usually in less than 24 hours).
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Pushed:
http://hg.mozilla.org/mozilla-central/rev/66b6e4eb8fe6

Thank you for this patch :)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.