Closed Bug 621039 Opened 14 years ago Closed 13 years ago

inputObj is never used in nsJSON::EncodeInternal

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 645922

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

226 nsJSON::EncodeInternal(nsJSONWriter *writer)

253   JSObject *inputObj = nsnull;

258   if (argc <= firstArg ||
259       !(JSVAL_IS_OBJECT(argv[firstArg]) &&
260         (inputObj = JSVAL_TO_OBJECT(argv[firstArg])))) {
261     // return if it's not something we can deal with
262     return NS_ERROR_INVALID_ARG;
263   }
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #499389 - Flags: review?(jst)
Attachment #499389 - Flags: approval2.0?
Comment on attachment 499389 [details] [diff] [review]
patch

Mass minusing patch approval that don't have high return. Please renominate if this is more important for 2.0 than it appears.
Attachment #499389 - Flags: approval2.0? → approval2.0-
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
Attachment #499389 - Flags: review?(jst)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: