621047 - 10-day averages don't always make sense for Orange Factor graphs

Status: RESOLVED FIXED

(Tree Management Graveyard :: OrangeFactor, defect, P1)

Description

[Mark Côté [:mcote]]

As you decrease the date range on the OrangeFactor/HeatMap pages, data points  disappear.

For example, looking at http://brasstacks.mozilla.com/couchdb/orange_factor/_design/woo/orange.html?display=HeatMap&startday=2010-10-01&endday=2010-10-27, I see a data point every day but starting only on the 11th.  If I "zoom" in to startday=2010-10-10&endday=2010-10-27, I see points from the 20th to the 27th.  Ad finally, startday=2010-10-20&endday=2010-10-27 shows nothing.

It appears that the first 10 days of a given period are not being displayed, for some reason, and hence if you give a range of < 10 days, nothing is displayed.

Comment 1

[Mark Côté [:mcote]]

Ah this is because the graphs display a 10-day average.  This might make sense for a large date range, but for smaller ones it's downright confusing.  Perhaps we should do away with the average altogether (we have other ways to see this), or at the very least change how we do the averaging based on the selected date range.

Comment 2

[Mark Côté [:mcote]]

We should use the raw date for everything, except when clearly noted (like the 7-day average in the bug details).

Comment 3

[Mark Côté [:mcote]]

Attachment: Calculate OF from start day, not 10 days later

This function also had some unused stuff, which I removed.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 501828 [details] [diff] [review]
Calculate OF from start day, not 10 days later

ok, this is good.  Should we removing the 7 day moving average on the bug details as well?

Comment 5

[Mark Côté [:mcote]]

I think the 7-day average is fine; it's clearly marked as such and is displayed alongside the daily average.  The 10-day average on OF was confusing because (a) it wasn't marked as such, and (b) caused the graph to start 10 days after the requested start day.  I don't think it was really serving a purpose, though we can add it back later if people want, alongside the daily average.

Pushed as http://hg.mozilla.org/automation/orangefactor/rev/d405cafb5f00