Closed
Bug 621087
Opened 14 years ago
Closed 13 years ago
Add-ons without icon should use the theme puzzle piece instead of AMO's
Categories
(addons.mozilla.org Graveyard :: API, enhancement, P5)
addons.mozilla.org Graveyard
API
Tracking
(Not tracked)
VERIFIED
FIXED
6.1.2
People
(Reporter: darktrojan, Assigned: andy+bugzilla)
References
Details
Attachments
(2 files)
1.05 KB,
patch
|
mossop
:
review-
|
Details | Diff | Splinter Review |
131.73 KB,
image/png
|
Details |
We'll also need to make sure AMO's default icon uses the same file name in future. My patch checks the file name but not the full path.
Attachment #499458 -
Flags: review?(dtownsend)
Comment 1•14 years ago
|
||
Comment on attachment 499458 [details] [diff] [review] patch This places an assumption that AMO is the add-ons site for the application and that it uses a particular default icon name, neither of these should be baked in to toolkit.
Attachment #499458 -
Flags: review?(dtownsend) → review-
Comment 2•14 years ago
|
||
The right solution here is to have AMO not include the icon in the API results when the icon is just the default one.
Assignee: geoff → nobody
Component: Add-ons Manager → API
Product: Toolkit → addons.mozilla.org
QA Contact: add-ons.manager → api
Reporter | ||
Comment 3•14 years ago
|
||
(In reply to comment #1) > Comment on attachment 499458 [details] [diff] [review] > patch > > This places an assumption that AMO is the add-ons site for the application and > that it uses a particular default icon name, neither of these should be baked > in to toolkit. Good point.
Status: ASSIGNED → NEW
Comment 4•13 years ago
|
||
This is about removing the default add-on icon fallback when it's being displayed in the API.
Assignee: nobody → amckay
Priority: -- → P5
Target Milestone: --- → Q2 2011
Updated•13 years ago
|
Target Milestone: Q2 2011 → 6.1.2
Assignee | ||
Comment 5•13 years ago
|
||
https://github.com/jbalogh/zamboni/commit/133439c2c3f153b34e17ba3c5887b8dd3e5b1431 As discussed with Mossop on irc, you'll get an empty <icon> now if there's no icon for the addon.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 6•13 years ago
|
||
verified at https://addons-next.allizom.org/en-US/firefox/api/1.5/search/imarios
Status: RESOLVED → VERIFIED
Comment 7•13 years ago
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•