621087 - Add-ons without icon should use the theme puzzle piece instead of AMO's

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, enhancement, P5)

Description

[Geoff Lankow (:darktrojan)]

Attachment: patch

We'll also need to make sure AMO's default icon uses the same file name in future. My patch checks the file name but not the full path.

Comment 1

[Dave Townsend [:mossop]]

Comment on attachment 499458 [details] [diff] [review]
patch

This places an assumption that AMO is the add-ons site for the application and that it uses a particular default icon name, neither of these should be baked in to toolkit.

Comment 2

[Dave Townsend [:mossop]]

The right solution here is to have AMO not include the icon in the API results when the icon is just the default one.

Comment 3

[Geoff Lankow (:darktrojan)]

(In reply to comment #1)
> Comment on attachment 499458 [details] [diff] [review]
> patch
> 
> This places an assumption that AMO is the add-ons site for the application and
> that it uses a particular default icon name, neither of these should be baked
> in to toolkit.

Good point.

Comment 4

[Wil Clouser [:clouserw]]

This is about removing the default add-on icon fallback when it's being displayed in the API.

Comment 5

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/133439c2c3f153b34e17ba3c5887b8dd3e5b1431

As discussed with Mossop on irc, you'll get an empty <icon> now if there's no icon for the addon.

Comment 6

[krupa raj[:krupa]]

verified at https://addons-next.allizom.org/en-US/firefox/api/1.5/search/imarios

Comment 7

[krupa raj[:krupa]]

Attachment: post-fix screenshot