621088 - Change URL structure to support separate feedback tracks

Status: VERIFIED FIXED

(Input :: General, defect, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load http://input.stage.mozilla.com/en-US/feedback with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20101222 Firefox/4.0b9pre

(Note: here, you'll get redirected to http://input.stage.mozilla.com/en-US/feedback/beta)

2. Click on either Happy or Sad (http://input.stage.mozilla.com/en-US/feedback/happy or http://input.stage.mozilla.com/en-US/feedback/sad)

Actual:

Keep getting redirected to /beta:

22:14:50.140: Network: GET http://input.stage.mozilla.com/en-US/feedback/sad [HTTP/1.1 302 FOUND 1512ms]
22:14:51.707: Network: GET http://input.stage.mozilla.com/en-US/feedback/beta [HTTP/1.1 200 OK 96ms]

Expected:

Probably should let me submit feedback using Minefield, or, if not, tell me to download the latest beta

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Ah, sorry; this is just bug 615729, isn't it?

Comment 2

[Fred Wenzel [:wenzel]]

Over to Aakash for a product decision: This is currently expected behavior (ergo, invalid). If a user uses a non-stable version (read: alpha, beta) and tries to visit the stable feedback pages, they get forwarded to the beta feedback pages.

Comment 3

[Aakash Desai [:aakashd]]

Ah, fun! If we want the correct user experience, then offering the /download page is the right way to go since we're only allowing for feedback in betas and stable versions of firefox. 

With that said...Stephen, does this approach hamper testing from QA at all? If so, we may want to look into adding something into the release checklist to better our processes around testing submission-related features for now in the future.

Comment 4

[Fred Wenzel [:wenzel]]

Aakash: Can you come up with a URL/user agent flow chart? It is currently expected that newer UAs get to see the feedback page (mostly, so that people on 4.0b9pre can leave feedback for 4.0b8). We can implement changes to the way it works after we come up with a comprehensive chart that we can point people to who think it is misbehaving.

Comment 5

[Aakash Desai [:aakashd]]

Aye, will do.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Nah, this doesn't adversely affect QA from testing, other than it'd be good to have the user-agent cases/flow spelled out (as Fred suggested in another bug).

Comment 7

[Paul Harvey]

Why not make /sad redirect to an alternative page if the version is more recent than stable?  Said page might give a basic how-to for QA Companion.

Comment 8

[Aakash Desai [:aakashd]]

Attachment: url charts for input 3.0

Here's the chart for URLs and build types for Firefox. Feedback and questions welcome.

Comment 9

[Fred Wenzel [:wenzel]]

I have a few comments:
- http://www.comicsanscriminal.com/  (no offense ;) )
- So we're not allowing any feedback from nightlies anymore? That makes me a little sad, but I guess that's consistent with us splitting up feedback intro three tracks.
- I think forwarding latest beta builds from feedback to beta/download is wrong. They already have the latest beta build. If anything we should forward them to the beta feedback page. Same for latest mobile betas.
- What's a "candidate for release" for a beta version? Isn't that a nightly?

Comment 10

[Aakash Desai [:aakashd]]

Attachment: URL chart (updated for stable)

Comment 11

[Fred Wenzel [:wenzel]]

Aakash: After we talked yesterday, I think we decided on putting release feedback under: /release/feedback. Is that right?

This would mean we'd need to change our URL structure some more and put the beta dashboard under /beta. We'd then add several intelligent redirects, from /feedback to /beta/feedback and /release/feedback, based on the UA, for example.

Comment 12

[Aakash Desai [:aakashd]]

Yep, thats right:

/release/feedback
/beta/feedback
/nightly/feedback
...etc.

Comment 13

[Fred Wenzel [:wenzel]]

This is ready to roll:
https://github.com/fwenzel/reporter/compare/master...url-structure-621088

Dave Dash: r?

This moves all current pages (except for the single opinion page) under /beta, and the new feedback pages under /release/feedback. This makes room in the namespace for new dashboards etc. I also changed (and tested) the UA detection on the feedback pages, according to the chart in comment 10.

Comment 14

[Fred Wenzel [:wenzel]]

Thanks for the review. I landed this here:

https://github.com/fwenzel/reporter/commit/e2e12c8

Comment 15

[Rebecca Billings [:rbillings]]

Verified

Comment 16

[Fred Wenzel [:wenzel]]

Summary: Firefox Input version 3.x currently supports feedback submissions for release and beta versions only. Nightly versions of Firefox cannot leave feedback until support is added in Firefox Input versions 4.x.

Comment 17

[David Lawrence [:dkl]]

Adding back the in-testsuite and in-litmus flags that were mistakenly removed.