621136 - Lightning 32/64 bit universal builds broken due to not referencing the correct location for components

Status: RESOLVED FIXED

Description

[Mark Banner (:standard8) (afk 15 - 18 Oct)]

Created attachment 499495 [details] [diff] [review]
The fix

Currently the universal builds for Mac are packaged with binary components like this:

platform/Darwin_x86-gcc3/components/libcalbasecomps.dylib
platform/Darwin_x86_64-gcc3/components/libcalbasecomps.dylib

The components.manifest just references the component:

binary-components libcalbasecomps.dylib

This is no longer valid as with the new manifest system it doesn't go searching per-platform.

Given the new method, my proposal is to locate them like this:

components/Darwin_x86-gcc3/libcalbasecomps.dylib
components/Darwin_x86_64-gcc3/libcalbasecomps.dylib

and use a components.manifest like this:

binary-component Darwin_x86-gcc3/libcalbasecomps.dylib ABI=Darwin_x86-gcc3
binary-component Darwin_x86_64-gcc3/libcalbasecomps.dylib ABI=Darwin_x86_64-gcc3

This both simplifies the layout and restores the functionality.

I'm attaching a patch that will do this, with that patch Lightning works for me on trunk Thunderbird. There are try server builds being generated and will be available here in a few hours:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/tryserver-builds/[e-mail]-5714757c154d

I don't mind who wants to review it. I'll land when I get review and we can always follow-up.

Comment 1

[Mark Banner (:standard8) (afk 15 - 18 Oct)]

Ok, so the try server builds are up. Not everything works in Lightning, but at least you can view the current month.

Comment 2

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 499495 [details] [diff] [review]
The fix

Thanks for taking care, r=philipp

Comment 3

[Mark Banner (:standard8) (afk 15 - 18 Oct)]

Checked in: http://hg.mozilla.org/comm-central/rev/51ba0686c49c