two (duplicate) Full Screen buttons appear in fullscreen mode

NEW
Unassigned

Status

()

Firefox
Theme
8 years ago
2 years ago

People

(Reporter: Arne Stenström, Unassigned)

Tracking

Trunk
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8) Gecko/20100101 Firefox/4.0b8

When the Full Screen button has been added to a toolbar, sometimes, depending on where the button was placed, two such buttons appear in fullscreen mode.

Reproducible: Always

Steps to Reproduce:
1. In a fresh profile, add the Full Screen button at the right end of the Navigation Toolbar.
2. Enter Full Screen mode.

Actual Results:  
Two Full Screen buttons appear on the toolbar in fullscreen mode

Expected Results:  
Only one Full Screen button should appear on the toolbar in fullscreen mode.

If the Full Screen button is added at some other places, for example the left end of the Navigation toolbar, the duplication does not occur.

Comment 1

8 years ago
I confirm this issue.
Duplicate of this bug: 621298

Comment 3

8 years ago
I confirm this issue in Firefox 4b10.

Comment 4

8 years ago
Created attachment 507972 [details]
How the fullscreen button is added in fs mode (FF4b10 OSX)

Comment 5

8 years ago
First, I did some testing in Windows (Firefox 4b11pre on Win7) and the problem doesn’t exist there. Then I did some more testing on OSX and can confirm that the issue persists in the latest FF4 nightly.

This is the current behavior in OSX:
- When going in fullscreen mode, Firefox tries to add a "Full Screen" button to the FIRST toolbar. Not a specific toolbar (navigation or tabs bar), but simply the topmost bar.
- The "Full Screen" button it adds uses the style for Navigation bar buttons, even if the toolbar it’s added to is the Tab bar.
- If the button is already present in the topmost toolbar, it is not added.
- If the button is already present in another toolbar, it is added to the topmost toolbar nonetheless.

If I remember correctly, on Windows Firefox doesn’t try to add the "Full Screen" button.

If the current basic behavior—making sure there is a "Full Screen" button available when in fullscreen mode—is wanted, the implementation must be fixed. Possible solutions (which may complement or contradict each other):
- Search ALL toolbars for a "Full Screen" button. Don’t add one if there’s already one.
- Always add button to the nav bar. If nav bar is disabled, either add to the topmost existing toolbar or don't add the "Full Screen" button at all.
- If adding to the topmost toolbar, test the toolbar type and make sure to use the right button style.
(Reporter)

Comment 6

7 years ago
Why has this bug still status "UNCONFIRMED"?
Status: UNCONFIRMED → NEW
Component: Toolbars → Theme
Ever confirmed: true
QA Contact: toolbars → theme
Version: unspecified → Trunk
(Reporter)

Updated

7 years ago
Summary: two Full Screen buttons appear in fullscreen mode → two (duplicate) Full Screen buttons appear in fullscreen mode
Duplicate of this bug: 638115

Comment 8

2 years ago
Created attachment 8815554 [details]
Screen Shot 2016-11-29 at 6.24.05 PM.png
You need to log in before you can comment on or make changes to this bug.