621453 - Clean up ContentParent cruft

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Josh Matthews [:jdm]]

ContentParent has accumulated some weird bits in GetSingleton that don't really make sense to me.  OnAccelerationChange is also funky, as it attempts to get a singleton for what is presumably the current object.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Clean up ContentParent cruft.

Comment 2

[Benjamin Smedberg]

Comment on attachment 499775 [details] [diff] [review]
Clean up ContentParent cruft.

I really hate that all the observer-adding is done in GetSingleton anyway. If you're going to refactor this, please move all that into an Init() method. That way when we have multiple content processes we don't have to touch this all yet again.

Comment 3

[Josh Matthews [:jdm]]

Attachment: Clean up ContentParent cruft.

Here's the Init() version.  I also noticed that the current thread observer mechanism will break when we move to multiple content processes, but that's not something I want to address right now.

Comment 4

[Josh Matthews [:jdm]]

Comment on attachment 511038 [details] [diff] [review]
Clean up ContentParent cruft.

This is good cleanup of some code that's become a bit of a dumping ground.

Comment 5

[Benjamin Smedberg]

Comment on attachment 511038 [details] [diff] [review]
Clean up ContentParent cruft.

Can you provide a risk/reward analysis? I really don't want to go taking cleanup patches at this point unless they fix some known issue.

Comment 6

[Josh Matthews [:jdm]]

Nevermind, there's no real need to take this right now.

Comment 7

[(no longer active)]

This patch doesn't apply cleanly on trunk anymore.

Comment 8

[Josh Matthews [:jdm]]

Attachment: Clean up ContentParent cruft.

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f008fc60b3d4