621457 - Showing 10 pushes on the front page will be misleading when we're busy

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: TBPL, defect)

Description

[Phil Ringnalda (:philor)]

While Tinderbox's default view of the last 12 hours didn't have any mystical rightness, it did have one thing going for it: under any reasonable circumstances, it kept builds visible until a while after they were completely built and tested out.

Say we have another long slow freeze of "b9 blockers only" leading into b9, so we build up a lot of approvals and reviews of > b9 blockers. One fine day, Toronto wakes up, tags b9 and reopens, and everyone in Toronto pushes their 20 pushes. They've all got tbpl open, so they'll keep seeing all their pushes unless they refresh, and will see that the first one caused ten test failures, but three hours later when MV wakes up, they'll see just the last ten pushes, which haven't even finished building yet, and will push into what looks to them like a perfectly acceptable tree with no unstarred orange.

If we're doing an initial load, and find that the oldest of the ten pushes is more recent than x hours, where x is at least 8 and probably 12 hours, we have to load another page, and keeping loading more until we get to one that's old enough.

Comment 1

[Phil Ringnalda (:philor)]

Took 12 hours after bug 621456 relanded the 10 push thing, but if you load tbpl right now, you will not be seeing all of the pushes that are still running tests.

Comment 3

[Arpad Borsos [:Swatinem]]

As we limit the first load to 24 hours to not overload tinderbox, we could as well increase the number of pushes.

Comment 4

[Phil Ringnalda (:philor)]

Neatly solved by making three people totally responsible for every tree where there might be more than 10 active pushes.