621491 - sort /all alphabetically and show 100 documents per page

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Kadir Topal [:atopal]]

Please sort the list of articles on /kb/all by alphabetically instead of the current unknown sorting, and please removing the paging. Contributors are looking through the page with Ctrl+f and that doesn't work well with 13 pages.

Comment 1

[James Socol [:jsocol, :james]]

Not paginating is a performance regression, and means performance on that page will get worse over time. What use case does that solve that can't be solved with search?

Comment 2

[Kadir Topal [:atopal]]

Since we don't really link this from the UI like we did before (on the startpage even), I'm not too worried about performance. 

I also suggest search, but some contributors are used to and even faster with Ctrl+f on a single page. If we can support that without breaking stuff, that's great :)

see https://support.mozilla.com/en-US/forums/contributors/704890

Comment 3

[James Socol [:jsocol, :james]]

(In reply to comment #2)
> Since we don't really link this from the UI like we did before (on the
> startpage even), I'm not too worried about performance. 

We should never say we don't care about performance in page processing (i.e. not a celery task). What about a compromise of 50-100 articles per page? That should increase it's Ctrl-f-ability without leaving load times unbounded.

Comment 4

[Kadir Topal [:atopal]]

Okay, until we have word from contributors, could you please go ahead and page with 100 articles per page. And since we are getting the database interface for 2.4.2, could you please sort this by most viewed articles first? That should be the most useful compromise.

Comment 5

[Paul Craciunoiu [:paulc]]

Ok this is easy so I'll just do it.

Comment 6

[Paul Craciunoiu [:paulc]]

Waiting on bug 624541 to avoid doing extra work. The query from there should be basically identical to the one needed here.

Comment 7

[James Socol [:jsocol, :james]]

(In reply to comment #6)
> The query from there should be
> basically identical to the one needed here.

Query? Please oh please use the ORM if possible.

Comment 8

[Erik Rose [:erik][:erikrose]]

Can't really use the ORM (without jumping through firey _private hoops) because of the left joins. You can't apply the category/tag/etc. filters to a RawQuerySet, and CachingRawQuerySet has no __len__ to make Paginator happy, so this is going to turn into a moderate to major thing.

Comment 9

[James Socol [:jsocol, :james]]

(In reply to comment #8)
> CachingRawQuerySet has no __len__ to make Paginator happy,

The one from Cache Machine? That, fwiw, sounds like a bug we should fix.

Comment 10

[James Socol [:jsocol, :james]]

Given that we have /en-US/contributors/most-visited now, which is already sorted by most-visited (and should be paginated, see bug 628339) why don't we sort alphabetically.

Sorting by most-viewed but without listing the data we're sorting by is weird, and a most-viewed sort *with* that data exists, it seems like we should take the simple route here and just sort alphabetically.

Comment 11

[Erik Rose [:erik][:erikrose]]

That also makes this a heck of a lot simpler and more likely to land in 2.4.3.

Comment 12

[Erik Rose [:erik][:erikrose]]

Landed in https://github.com/jsocol/kitsune/commit/90bcd8bcf6d66cf6fd805b39df610070189b741f.

Comment 13

[Rebecca Billings [:rbillings]]

Verified /kb/all is now sorted alphabetically

Comment 14

[Kadir Topal [:atopal]]

Thanks guys, it makes much more sense this way indeed.