621497 - Can't see the form for uploading a new avatar

Status: RESOLVED DUPLICATE of bug 610369

(Tech Evangelism Graveyard :: English US, defect)

Description

[Gabriel Koritzky]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: 4.0b8

Part of this page's content does not show.

How it looks like in Firefox Beta 4:
http://img832.imageshack.us/img832/1123/firefoxy.png

How it looks like in IE and other browsers:
http://img843.imageshack.us/img843/569/48521456.png


The source code for Firefox
http://www.2shared.com/document/CHnb7wVU/firefox_source.html

Reproducible: Always

Steps to Reproduce:
1. Log in to lyrics wikia
2. Go the the preferences page ( http://lyrics.wikia.com/Special:Preferences )
3. Scroll down to the section entitled "Avatar"
Actual Results:  
The portion of the page which should display options for changing a user avatar does not show up.

Expected Results:  
It should (obviously) show up

Comment 1

[Boris Zbarsky [:bzbarsky]]

> http://www.2shared.com/document/CHnb7wVU/firefox_source.html

That seems to be a Windows executable.

In any case, the problem is that the script that does this:

		$.loadYUI(function() {
                  // etc

runs before '$' is defined.  And that happens because of this gem:

  this.useDOMInjection=b.indexOf("opera")!=-1||b.indexOf("firefox")!=-1;

  WikiaScriptLoader.prototype= {
    loadScript:  function(b,c) {
      this.useDOMInjection ?
       this.loadScriptDOMInjection(b,c) : 
       this.loadScriptDocumentWrite(b,c)
    }

So the site runs totally different script in IE/Webkit on the one hand and in Firefox/Opera on the other.  But the IE codepath works just fine in Firefox, while the other codepath relies on Firefox-specific behavior that we dropped because the HTML5 spec aligned with IE on script loading.

So the site just needs to remove all that browser sniffing and run the same code for all browsers instead of trying to be clever and screwing it up.

Gabriel, please contact the site maintainers about this?

Comment 2

[Gabriel Koritzky]

Will do, thanks.

Comment 4

[Henri Sivonen (:hsivonen)]

Wikia has already been informed. This problem is Wikia Support Request #91538.