621517 - Sync UI: Add a Device wizard pixel-shifts while validating J-PAKE pin

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[mcdavis941 (sporadically reading bugmail)]

The vertical positions of elements in the Add a Device wizard shift position based on whether the throbber and/or error message are shown.

A polish nit, and not something most users would probably notice, but fairly noticeable if you're looking for it.

It looks like what's happening is:
1 - The wizard page contains several spacers with vertical flex.
2 - While the pin is being entered, the throbber and the error status message have height 0, and the spacers have a certain height.
3 - While the throbber is shown, the throbber has height 16, and the flex height of the spacers changes.
4 - While the error message is shown, the error message has height 20, and the flex height of the spacers changes again, to a third value.

STR:
1 - Start Firefox nightly with a profile that is already set up with a Sync account.
2 - Open Firefox options/preferences window to the Sync pane.
3 - Click 'add a device' to open the Add a Device wizard.
4 - In the wizard, enter some random garbage pin.
5 - This should show first the throbber, then the error message, which should show the shifting vertical positions.

Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b9pre) Gecko/20101226 Firefox/4.0b9pre

Comment 1

[mcdavis941 (sporadically reading bugmail)]

Attachment: screenshot

Comment 2

[Marina Samuel [:emtwo]]

Attachment: patch for bug 621517

Comment 3

[Marina Samuel [:emtwo]]

Attachment: screenshot of result from fix

Comment 4

[Marina Samuel [:emtwo]]

Comment on attachment 528960 [details] [diff] [review]
patch for bug 621517

rnewman: added you to review this one as well then.

Comment 5

[Richard Newman [:rnewman]]

(In reply to comment #4)
> rnewman: added you to review this one as well then.

:)

Repro'ing now.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 528960 [details] [diff] [review]
patch for bug 621517

<3 polish!

Comment 7

[Philipp von Weitershausen [:philikon]]

Pushed: http://hg.mozilla.org/services/services-central/rev/6c2b6aea1d89

Hooray! Awesome job, Marina!

Comment 8

[Tracy Walker [:tracy]]

Verified with s-c builds of 20110502

Comment 9

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/6c2b6aea1d89