Closed Bug 621517 Opened 11 years ago Closed 10 years ago

Sync UI: Add a Device wizard pixel-shifts while validating J-PAKE pin


(Firefox :: Sync, enhancement)

Not set





(Reporter: mcdavis941.bugs, Assigned: emtwo)


(Whiteboard: [good first bug][verified in services])


(2 files, 1 obsolete file)

The vertical positions of elements in the Add a Device wizard shift position based on whether the throbber and/or error message are shown.

A polish nit, and not something most users would probably notice, but fairly noticeable if you're looking for it.

It looks like what's happening is:
1 - The wizard page contains several spacers with vertical flex.
2 - While the pin is being entered, the throbber and the error status message have height 0, and the spacers have a certain height.
3 - While the throbber is shown, the throbber has height 16, and the flex height of the spacers changes.
4 - While the error message is shown, the error message has height 20, and the flex height of the spacers changes again, to a third value.

1 - Start Firefox nightly with a profile that is already set up with a Sync account.
2 - Open Firefox options/preferences window to the Sync pane.
3 - Click 'add a device' to open the Add a Device wizard.
4 - In the wizard, enter some random garbage pin.
5 - This should show first the throbber, then the error message, which should show the shifting vertical positions.

Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b9pre) Gecko/20101226 Firefox/4.0b9pre
Attached image screenshot (obsolete) —
Whiteboard: [good first bug]
Assignee: nobody → msamuel
Attachment #528960 - Flags: review?(philipp)
Attachment #499828 - Attachment is obsolete: true
Attachment #528961 - Flags: review?(philipp)
Comment on attachment 528960 [details] [diff] [review]
patch for bug 621517

rnewman: added you to review this one as well then.
Attachment #528960 - Flags: review?(philipp) → review?(rnewman)
(In reply to comment #4)
> rnewman: added you to review this one as well then.


Repro'ing now.
Severity: normal → enhancement
OS: Windows Vista → All
Hardware: x86 → All
Comment on attachment 528960 [details] [diff] [review]
patch for bug 621517

<3 polish!
Attachment #528960 - Flags: review?(rnewman) → review+
Attachment #528961 - Flags: review?(philipp)

Hooray! Awesome job, Marina!
Whiteboard: [good first bug] → [good first bug][fixed in services]
Verified with s-c builds of 20110502
Whiteboard: [good first bug][fixed in services] → [good first bug][verified in services]
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.