621583 - Uploading an add-on icon doesn't save changes

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Log in as a Developer/Admin, and load https://addons.allizom.org/z/en-US/developers/addon/stephen3000-just-a-_test_-add-/edit
2. Try to upload any custom image (preview shows up now)
3. Click Save Changes

Actual Results:

Image's preview works at first, but then the div collapses and the changes are never saved

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Screencast!  http://www.screencast.com/users/stephendonner/folders/Jing/media/483056c7-6138-4b3e-a0fd-2f9e490f81aa

Comment 3

[Andy McKay]

In my case its shown, eventually. It's going on to a queue to be processed and until then, you get the old icon.

Would showing a message along the lines of "your icon may take a few minutes to show up" be appropriate?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #3)
> In my case its shown, eventually. It's going on to a queue to be processed and
> until then, you get the old icon.
> 
> Would showing a message along the lines of "your icon may take a few minutes to
> show up" be appropriate?

They're supposed to be in the redis fast queue, I thought, per bug 611621; maybe something regressed?

Comment 5

[Andy McKay]

It's on a fast queue, but it depends just fast that redis queue is, or what's in it at the time. Because its async there's no guarantee who gets there first, the icon or the response.

https://github.com/jbalogh/zamboni/commit/e783f1a8ce837560e81c4075c9c7469abc9bb632

We tried a few things and this is the current state, although its not perfect. It polls to see if the icon has been created. This can be hard to test.

I made a video of how its meant to work locally, its easy to slow down celery locally, although I don't show the default icon in local (just a blank space).

http://www.screencast.com/users/andymckay/folders/Jing/media/3b0bc7e1-c55e-4ee4-8339-22822c368f48

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.