621587 - Storage server breaks if no cache defined

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

Attachment: fix, no tests

Trying to run the Python server (server-full) locally against sqlite breaks for me since syncstorage.wsgiapp.StorageServerApp assumes self.cache exists.

(development.ini no longer refers to sqlite.conf by default which is a change I personally don't agree with because it means the server is no longer zero-conf. It may also be part of the reason why this bug wasn't caught earlier.)

Comment 1

[Tarek Ziadé (:tarek)]

(In reply to comment #0)
> Created attachment 499897 [details] [diff] [review]
> fix, no tests
> 
> Trying to run the Python server (server-full) locally against sqlite breaks for
> me since syncstorage.wsgiapp.StorageServerApp assumes self.cache exists.

These two options are mutually inclusive. I'll also need to raise an error at initialization in that case (+test). Will do when I am back from vacation.

> 
> (development.ini no longer refers to sqlite.conf by default which is a change I
> personally don't agree with because it means the server is no longer zero-conf.
> It may also be part of the reason why this bug wasn't caught earlier.)

It's unrelated and was an unintended change. I accidentally committed my modified development file when I committed some doc. Will fix it as well.

Comment 2

[Tarek Ziadé (:tarek)]

# Revert the config: http://hg.mozilla.org/services/server-full/rev/7d57979a3241
# Make sure the app cannot be initialized if Memcache is not present, and if check_blacklisted_nodes is set to true: http://hg.mozilla.org/services/server-storage/rev/c534b608ab51