621593 - nsPluginHost.cpp:3432:37: warning: missing terminating ' character

Status: RESOLVED DUPLICATE of bug 620668

(Firefox :: General, defect)

Description

[Nitebirdz]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20101227 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20101227 Firefox/4.0b9pre

Build error on Mac OS X v10.5.0:

...
nsIPluginStreamListener.idl
nsIPluginInstance.idl
nsIPluginHost.idl
nsIPluginDocument.idl
nsNPAPIPlugin.cpp
nsNPAPIPluginInstance.cpp
nsNPAPIPluginStreamListener.cpp
nsPluginStreamListenerPeer.cpp
nsPluginHost.cpp
nsPluginModule.cpp
nsJSNPRuntime.cpp
/Users/jesus/src/mozilla/modules/plugin/base/src/nsPluginHost.cpp:3432:37: warning: missing terminating ' character
/Users/jesus/src/mozilla/modules/plugin/base/src/nsPluginHost.cpp:3432: error: missing terminating ' character





Reproducible: Always

Steps to Reproduce:
1.hg clone http://hg.mozilla.org/mozilla-central/ mozilla
2.cd mozilla
3.make -f client.mk build
Actual Results:  
Simply try to build latest version available from the trunk as of 27/12/2010 at 11:39 PM CET.   

Expected Results:  
Complete build.

Problem appears to be a simple typo in file "modules/plugin/base/src/nsPluginHost.cpp":

---------------------------
diff -r fdbca21063bf modules/plugin/base/src/nsPluginHost.cpp
--- a/modules/plugin/base/src/nsPluginHost.cpp  Sun Dec 26 22:36:33 2010 +0000
+++ b/modules/plugin/base/src/nsPluginHost.cpp  Mon Dec 27 23:49:37 2010 +0100
@@ -3424,17 +3424,17 @@ nsPluginHost::HandleBadPlugin(PRLibrary*
   nsCString pluginname;
   if (pluginTag) {
     if (!pluginTag->mName.IsEmpty()) {
       pluginname = pluginTag->mName;
     } else {
       pluginname = pluginTag->mFileName;
     }
   } else {
-    pluginname.AppendLiteral("???");'
+    pluginname.AppendLiteral("???");
   }

   NS_ConvertUTF8toUTF16 msg(pluginname);
   msg.AppendLiteral("\n\n");
   msg.Append(message);

   PRInt32 buttonPressed;
   PRBool checkboxState = PR_FALSE;
---------------------------

Comment 1

[Makoto Kato [:m_kato]]

This is fixed by changeset 572175c2a64f