621715 - runxpcshelltests.py clobbers LD_LIBRARY_PATH

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Philippe M. Chiasson (:gozer)]

I just discovered that runxpcshelltests.py, in needing to add the runtime path to LD_LIBRARY_PATH, also clobberes any pre-existing LD_LIBRARY_PATH in

https://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#175

This, in the instance that I've hit, prevents running xpcshell tests on comm-central trunk, since we need a specific LD_LIBRARY_PATH set until we fully switch to the new GCC.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Not actually my patch - after I pushed my broken one which was stealing (poorly) from mozmill to ThunderbirdTry, I saw that jhopkins had already pushed a better one, which eventually worked once TbTry started actually passing LD_LIBRARY_PATH in.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 500640 [details] [diff] [review]
Fix v.1

The ":".join bit seems excessive, self.xrePath + ":" + self.env["LD_LIBRARY_PATH"] would be fine, but it's not a deal breaker.

Comment 4

[Phil Ringnalda (:philor)]

Excessive, but idiomatic (and better than the also idiomatic, and even more excessive, way that I was going to steal from mozmill, http://mxr.mozilla.org/comm-central/source/mozilla/testing/mozmill/mozrunner/mozrunner/__init__.py#373). Dunno whether Python really is terrible at concatting strings, or it's just historical avoidance of some perf problem concatting a thousand in a tight loop in Python 1.0, but Python people avoid "foo" + "bar" like the plague.

checkin-needed BEWARE: I told myself "I'll just push to try and strip off the trychooser bit from the message and export so it will be ready to land" but something shiny distracted me, so if someone gets to it before me, please remember to get rid of the try:... in the commit message.

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/mozilla-central/rev/343baa8939cc

Comment 6

[(not currently active) Ted Mielczarek]

String concatenation via + is only frowned upon in loops in Python, AFAIK. I think if you're only concatenating two strings you don't win anything by using join.