621750 - Make Help Icons smaller

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Chris Howse [:chowse]]

Attachment: Screenshot

The help icons that appear next to labels are almost twice as big as the label itself. How about a smaller icon?

Example: https://addons.allizom.org/z/en-US/developers/addon/he-heha-ha-2/edit

I'd also recommend showing the hover-tip if the user hovers anywhere over the label, not just the icon.

Comment 1

[Chris Howse [:chowse]]

Attachment: Suggested Size

Here's the icon I'd recommend: 13x13px. I'll also attach an image to use as a background instead of the question mark text (which tends to get misaligned and make the icon larger than it needs to be).

Comment 2

[Chris Howse [:chowse]]

Attachment: Question Mark Icon

Comment 3

[Wil Clouser [:clouserw]]

Your icon is blank, afaict, but we're doing this with CSS anyway I think.

Comment 4

[Justin Scott [:fligtar]]

It's a question mark. Drag it over the toolbar with a dark Persona installed!

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> It's a question mark. Drag it over the toolbar with a dark Persona installed!

I was looking at it in chromium. :(

Comment 6

[Justin Scott [:fligtar]]

You trusted Chromium enough to accuse the chowse of uploading a blank image? You're lucky he only uses his Creative Suite powers for good.

Comment 7

[Wil Clouser [:clouserw]]

This is a good first bug because the question mark is in a shared library so this change is only 1 or 2 lines.

Comment 8

[Irtefa]

I am a noob, where do you have to go to fix this bug?

Comment 9

[Christopher Van Wiemeersch [:cvan]]

(In reply to irtefafall2010 from comment #8)
> I am a noob, where do you have to go to fix this bug?

Probably want to start here: https://github.com/mozilla/zamboni/blob/master/media/css/devhub/forms.less#L3

Here's the documentation for installing AMO locally:
http://mozilla.github.com/zamboni/topics/installation.html

You'll also need to set up redis, memcached, and LESS (CSS):
http://mozilla.github.com/zamboni/topics/advanced-installation.html

Comment 10

[Xavier Antoviaque]

I gave it a shot.

As discussed on IRC, I submitted as a pull request on GitHub: https://github.com/mozilla/zamboni/pull/347

Please be gentle, it's my first patch. : )

Comment 11

[hilaryho]

Is the last pull request been review? Is it okay if I take up this bug and work on it? Who shall I send the pull request to in Github?

Comment 12

[Wil Clouser [:clouserw]]

Sending a pull request to the whole team is fine.  Xavier had a patch mostly done in comment 10 but didn't have time to finish it.  You might have good luck building off of it.  Thanks.

Comment 13

[Casey Becking]

This one doesn't looked to be worked on lately, can i take it on?

Comment 14

[Wil Clouser [:clouserw]]

(In reply to Casey Becking from comment #13)
> This one doesn't looked to be worked on lately, can i take it on?

hilaryho didn't get back to us, so sure.  The patch from comment 10 had this pretty much done as I recall.

Comment 15

[Casey Becking]

Really want to take this on but having issues just setting up the environment.

Comment 16

[Amol Pol]

I am a beginner in this field of mozilla bug fixing. Please help me with the procedure for fixing this bug.

Comment 17

[Christopher Van Wiemeersch [:cvan]]

(In reply to Amol Pol from comment #16)
> I am a beginner in this field of mozilla bug fixing. Please help me with the
> procedure for fixing this bug.

Hi Amol, thanks for your interest. Please read instructions on setting up Zamboni here:

    http://zamboni.readthedocs.org/en/latest/topics/install-zamboni/installation.html

If it's easier to read, you can read some of the commands here:

    https://gist.github.com/cvan/4742341

If you have specific questions you can find me in #amo on irc.mozilla.org:6697. Thanks!

Comment 18

[Bablu Kumar]

sir
I want to work on this bug.it will be great to work on this bug.kindly assign it to me
thank you

Comment 19

[Wil Clouser [:clouserw]]

Follow the advice in comment 17.  If you send a pull request that closes the bug I'll assign it to you.

Comment 20

[hello]

First time contributing :)

Submitted a pull request https://github.com/mozilla/zamboni/pull/692

Do let me know if I'm not following the proper procedure.

Comment 21

[Christopher Van Wiemeersch [:cvan]]

Andy merged this in https://github.com/mozilla/zamboni/commit/03943abda but looks like we have a regression: bug 859810.

Comment 22

[Christopher Van Wiemeersch [:cvan]]

Reverted: https://github.com/mozilla/zamboni/commit/b427ae7

Comment 23

[Samiullah]

(In reply to Chris Howse [:chowse] from comment #0)

Hi Chris 

I would want to help fix this bug, can you assign it to me please. I will be attempting to fix the bug, thank you.

Comment 24

[Samiullah]

Hi Chris 

I would want to help fix this bug, can you assign it to me please. I will be attempting to fix the bug, thank you.

Comment 25

[Samiullah]

Hi Chris 

I would want to help fix this bug, can you assign it to me please. I will be attempting to fix the bug, thank you.

Comment 26

[Vick Makifina]

Hi Chris i have just finished installing and testing the build environment, i would appreciate the opportunity to solve this bug. Please let me tackle it...... Thanks.

Comment 27

[Zulfa]

Hi Chris

I would like to be assigned to this bug, I have previous experience in html and css, so this would be a first good bug for me to tackle.
Thanks.

Comment 28

[Zulfa]

Hi Chris

I would like to be assigned to this bug, I have previous experience in html and css, so this would be a first good bug for me to tackle.
Thanks.

Comment 29

[Wil Clouser [:clouserw]]

Anyone is welcome to do this bug, send a pull request with your change.

Comment 30

[Emerson Veenstra [:emerson]]

Is this still a bug? I can't find anywhere on addons.allizom that those question marks appear.

Comment 31

[Wil Clouser [:clouserw]]

(In reply to Emerson Veenstra [:emerson] from comment #30)
> Is this still a bug? I can't find anywhere on addons.allizom that those
> question marks appear.

Yes, click "edit" on one of your add-ons.

Comment 32

[Rajendra Vankadari]

Hello Christopher,
I am a new bee, I tried to install ZAMBONI with the instructions you have specified, but it only has installation set up for ubuntu,os x where as i use windows. 
Can you please send the setup info for Windows as well.


(In reply to Christopher Van Wiemeersch [:cvan] from comment #9)
> (In reply to irtefafall2010 from comment #8)
> > I am a noob, where do you have to go to fix this bug?
> 
> Probably want to start here:
> https://github.com/mozilla/zamboni/blob/master/media/css/devhub/forms.less#L3
> 
> Here's the documentation for installing AMO locally:
> http://mozilla.github.com/zamboni/topics/installation.html
> 
> You'll also need to set up redis, memcached, and LESS (CSS):
> http://mozilla.github.com/zamboni/topics/advanced-installation.html

Comment 33

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/