Closed Bug 621757 Opened 10 years ago Closed 10 years ago

Sync UI: Allow pasting the Sync Key with the mouse in setup wizard and Update Sync Key dialog

Categories

(Firefox :: Sync, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: bugzilla, Assigned: philikon)

References

Details

(Whiteboard: [has patch][has review])

Attachments

(1 file)

I copied the sync key to the clipboard from my other PC when the went to "Change my Sync key" dialog. Then I rightclick on the input field and select "paste" and the "Chaneg Sync Key" button didn't get activated. I had to type a blank character to activate the button.
Some of the code there is wrong, since keyboard interaction should not be required.

Mozilla/5.0 (Windows NT 5.1; rv:2.0b9pre) Gecko/20101228 Firefox/4.0b9pre ID:20101228030339
Yes, good point. We should probably not be using onkeyup here but oninput.
Assignee: nobody → philipp
blocking2.0: --- → ?
Yup, users use the mouse to copy and paste a lot.
blocking2.0: ? → betaN+
Attached patch v1Splinter Review
UL IS AWESOME
Attachment #501200 - Flags: review?(mconnor)
Whiteboard: [has patch][needs review mconnor]
Attachment #501200 - Flags: review?(mconnor) → review+
Whiteboard: [has patch][needs review mconnor] → [has patch][has review]
Summary: "Change Sync Key" button doesn't get enabled when using the mouse to paste new sync key → Sync UI: Allow pasting the Sync Key with the mouse in setup wizard and Update Sync Key dialog
http://hg.mozilla.org/mozilla-central/rev/898dc02747b6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
OS: Windows XP → All
No longer blocks: 615950
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.