621779 - Cannot see more than 6 tabs when VKB is opened in portrait mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Ayan Shah[:ashah]]

Attachment: screenshot of 6 tabs

Mozilla/5.0 (Android; Linux armv71; rv:2.0b9pre) Gecko/20101227
Firefox/4.0b9pre Fennec/4.0b4pre

1. Open Fennec
2. Open 8 to 9 tabs
3. In one of the tab(preferable the last tab), open a webpage that has a text box (eg. www.yahoo.com)
4. Click on the textbox to bring up the virtual keyboard
5. Slide the page to the right to reveal the tabs

Actual result:
I can see only 6 tabs. I cannot pan to reveal the other tabs

Expected result:
I can see/pan all my tabs

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Looks like exactly what bug 607841 was supposed to do.

>Expected result:
>I can see/pan all my tabs

Any thoughts on how this could be achieved? What are your expectations regarding panning while the VKB is open?

Comment 2

[Ayan Shah[:ashah]]

> Any thoughts on how this could be achieved? What are your expectations
> regarding panning while the VKB is open?

Not sure but may be we can allow a horizontal pan on the tabs. Because right now, there is not way I can see after 6 tabs.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch add a max-width for the tabs container and allow panning tabs if needed.

This will leave 2 columns in portrait mode and 4 in landscape mode.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch updated

Updated patch on trunk, also I've removed r? since I've found a few bugs. I've give a build to Madhava to have his opinion (http://vingtetun.org/build/tabs.apk)

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

There is a build at http://vingtetun.org/build/tabs-new.apk for those who want to try.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.3

I have spoke with Madhava yesterday and he is agree for 2 tabs and a half on both portrait and landscape.

browser_sidebars.js still works with this patch applied.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/40de821d2c78

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b12pre) Gecko/20110210 Firefox/4.0b12pre Fennec/4.0b5pre