621877 - No Sync panel in preferences of localized builds in Firefox Sync 1.6.1

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Alexander L. Slovesnik]

1. Install Firefox Sync 1.6.1 in localized build.
2. Open Tools - Preferences

Expected results: Sync panel shown
Actual results: Sync panel doesn't show

The reason is this string:

<!ENTITY addDevice.label              "Add a Device">

that present only in en-US prefs.dtd file.

Comment 1

[Axel Hecht [:Pike]]

I suspect that the weave-l10n/en-US repo is out-of-date, at least http://hg.mozilla.org/services/fx-sync/rev/66abf623debf seems to be not ported.

No idea what the impact of that is on the builds that mconnor does.

Comment 2

[Mike Connor [:mconnor]]

Actually, this was just built with the wrong build script, so l10n-merge was off.

Comment 3

[Axel Hecht [:Pike]]

l10n-merge can only fix what it finds, so it depends if you're using the fx-sync strings for it, or the weave-l10n/en-US repo.

But yeah, it should've been built with l10n-merge on.

Comment 4

[Philipp von Weitershausen [:philikon]]

Yup, my bad, was using an outdated build script it appears. E_TOO_MANY_BUILD_SCRIPTS

Comment 5

[Philipp von Weitershausen [:philikon]]

Respun and uploaded a new 1.6.1 build. Tested with a German Firefox.

Comment 6

[Tracy Walker [:tracy]]

Verified with 3.6.13 and 1.6.1 on Mac ja-JP-mac and XP pt-BR

Comment 7

[Tony Chung [:tchung]]

also verified on Fx3.6.3, 1.6.1 and ja on Win7