Closed Bug 621892 Opened 9 years ago Closed 9 years ago

Reflow zoom goes to the wrong y coordinate if layout changes

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Steps to reproduce:
0. Enable "Reformat text on zoom".
1. Open http://daringfireball.net/ in portrait mode on device, or in a narrow window on desktop.
2. Scroll at least halfway down the page.
3. Double-tap on a paragraph of text.

Expected results: Fennec zooms in on tapped paragraph.
Actual results: Fennec zooms in on a completely different part of the page.

Text reflow may cause an element to move up or down.  _getZoomRectForRect uses the correct X coordinates of the element's bounding rect, but we still use the original Y coordinate without updating it.  This patch fixes that.
Attachment #500193 - Flags: review?(21)
http://hg.mozilla.org/mobile-browser/rev/260416bfa497
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified - Mozilla/5.0 (Android; Linux armv7l; rv:2.2a1pre) Gecko/20110325 Firefox/4.2a1pre Fennec/4.1a1pre ID:20110325041944
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.