621892 - Reflow zoom goes to the wrong y coordinate if layout changes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
0. Enable "Reformat text on zoom".
1. Open http://daringfireball.net/ in portrait mode on device, or in a narrow window on desktop.
2. Scroll at least halfway down the page.
3. Double-tap on a paragraph of text.

Expected results: Fennec zooms in on tapped paragraph.
Actual results: Fennec zooms in on a completely different part of the page.

Text reflow may cause an element to move up or down.  _getZoomRectForRect uses the correct X coordinates of the element's bounding rect, but we still use the original Y coordinate without updating it.  This patch fixes that.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 500193 [details] [diff] [review]
patch

Makes sense to me

Comment 2

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/260416bfa497

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Verified - Mozilla/5.0 (Android; Linux armv7l; rv:2.2a1pre) Gecko/20110325 Firefox/4.2a1pre Fennec/4.1a1pre ID:20110325041944