621894 - Add preview on review page

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Kadir Topal [:atopal]]

As per contributor request, please add a preview of the revision to be reviewed to the review page.

Comment 1

[James Socol [:jsocol, :james]]

We already show both the source of the revision and the rendered output on the review page. I'm not sure what more "preview" we can give?

Comment 2

[Kadir Topal [:atopal]]

Hmm, maybe I'm doing something wrong, but I don't see a rendered version here: https://master.support.mozilla.com/en-US/kb/home-page-explore/review/5787

Comment 3

[James Socol [:jsocol, :james]]

Oh, no, I was doing something wrong: apparently we only show the rendered version when reviewing the first revision[1].

This will make the review page pretty long, I suggest we make the sections collapsible like we've done on other pages.

[1] https://master.support.mozilla.com/en-US/kb/review-me/review/5795

Comment 4

[Kadir Topal [:atopal]]

Right. I agree with that approach, for minimal changes it won't be necessary to see it anyway, so making it collapsible makes sense.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/jsocol/kitsune/commit/562c5c63c6796f28775ca57891eac13cf4a21e37

Comment 6

[Rebecca Billings [:rbillings]]

Verified it displays now