622032 - Give some indication that we called InstallTrigger after a button click

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[Jeff Balogh (:jbalogh)]

On a slow internet connection it can take a long time for the AOM to do whatever it does in the background before triggering the addon popup.  I waited for a few seconds wondering if my button click was actually registered.

We could start a spinner that would get turned off with the success callback from the AOM.

Comment 1

[Wil Clouser [:clouserw]]

Ugh, this happens to me all the time.  CCing chowse to see if he has great ideas, but yeah, we should do something

Comment 2

[Chris Howse [:chowse]]

What I'd recommend:

1. While installing, give the button the same style as 'older version' buttons:
   white background, light blue border, and blue text. I believe
   '.button.concealed' captures most of the style.

2. Change the label from 'Add to Firefox' to 'Installing...'.

3. Replace the plus icon with a spinner.

4. Disable any input, focus, and hover effects on the button until the
   install is complete.

5. Revert the button to its original style afterwards.

Comment 3

[Chris Howse [:chowse]]

Attachment: Screenshot of a the button mid-install

Comment 4

[Chris Howse [:chowse]]

Attachment: Spinner image

Comment 5

[Potch [:potch]]

am I correct in assuming the spinner is the same as the one we use across the site?

Comment 6

[Chris Howse [:chowse]]

(In reply to comment #5)
> am I correct in assuming the spinner is the same as the one we use across the
> site?

Unfortunately, no. Different size, color and background (an unfortunate requirement of animated GIFs).

APNG or SVG+SMIL might work, if I had the time and tools to make either.

Comment 7

[Justin Scott [:fligtar]]

FYI: the reason this is such a problem is that Firefox 4 actually downloads the entire add-on before it pops the install dialog. It's really Firefox's fault that there's no UI indication of this, and it was something that was going to be worked on at some point, but it would be awesome if we could do something too.

Comment 8

[Wil Clouser [:clouserw]]

mossop: Does Firefox fire a callback when it's done downloading that we can trigger off of?

Comment 9

[Jeff Balogh (:jbalogh)]

(In reply to comment #8)
> mossop: Does Firefox fire a callback when it's done downloading that we can
> trigger off of?

https://developer.mozilla.org/en/XPInstall_API_Reference/InstallTrigger_Object/Methods/install

We already use the callback for redirecting to contributions after installation.

Comment 10

[Dave Townsend [:mossop]]

Note that bug 570012 should be landing today or so which will give immediate feedback in Firefox 4. Firefox 3 is less of an issue as it only downloads 4k or so before showing the install dialog.

Comment 11

[Wil Clouser [:clouserw]]

wontfix due to comment 10, thanks