622046 - Decryption failure on client record

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Firefox Home, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I have Home in a state where it immediately fails during the second sync. The initial sync is fine.

Upon inspection it looks like the Client Record that was found does not match the encryption key. Home throws an exception and aborts sync.

This does not happen during initial sync because there Home ignores exceptions from fetchAndUpdateClientRecord. These exceptions are not ignored during subsequent sync sessions.

So I assume this is an old record, left over from an older sync session. I'm not sure how this can happen but it is a situation that Home should properly deal with. (Looking at the code, Home never handled this)

Comment 1

[Ragavan S [:rags]]

Can you recover from this state? And can you list STR so we can try to reproduce as well?

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Sorry I should have mentioned this. There is no simple way to recover from this by just using your iPhone. The only thing you can do is a Reset Sync from the Desktop, assuming that also removes all clients records. (Needs to be confirmed)

I was not able to reproduce this yet but I'm pretty sure it can happen when upgrading from 1.5 to 1.6 in the case where the upgrade also caused a key change. Then the old client record sticks around and cannot be loaded by Home.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Workaround implemented in 1.1.1
http://hg.mozilla.org/services/fx-home/rev/984e9721cb15

This is hard to test. I tested this by running the python server and then manually corrupting the client record in the sqlite database.

Comment 4

[Tony Chung [:tchung]]

(In reply to comment #3)
> Workaround implemented in 1.1.1
> http://hg.mozilla.org/services/fx-home/rev/984e9721cb15
> 
> This is hard to test. I tested this by running the python server and then
> manually corrupting the client record in the sqlite database.

help, how can i test this

Comment 5

[Tony Chung [:tchung]]

qa- means unable to manually verify this bug.