622198 - Remove BSD and Solaris from platform drop-down box

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons.allizom.org/z/en-US/developers/addon/fargo/versions/121908
2. Notice the list of platforms in the drop-down box besides the add-on file.

observed behavior:
BSD and Solaris are listed as platform options.

Comment 1

[krupa raj[:krupa]]

Attachment: screenshot

Comment 2

[Andy McKay]

What would we do with old files that are for BSD or Solaris? They wouldn't be there in the drop down.

Comment 3

[Wil Clouser [:clouserw]]

Can we only show the dropdown if the files already exist with those options?  I'd like them to go the way of the dinosaur

Comment 4

[Andy McKay]

How about we only show BSD or Solaris in the drop down if that file is for BSD or Solaris. That way you can't change a file BSD or Solaris - but you can leave it alone or change it to something else.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> How about we only show BSD or Solaris in the drop down if that file is for BSD
> or Solaris. That way you can't change a file BSD or Solaris - but you can leave
> it alone or change it to something else.

That's what I had in my head, but failed to translate into words. :(  Thanks!

Comment 6

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/367cf2e40769b54eb5c135cb116449963343735b

Comment 7

[krupa raj[:krupa]]

verified that BSD and Solaris are not listed as options anymore @ https://addons.allizom.org/z/en-US/developers/addon/jebfhjbvefjbv/versions/121773

checked that for files which are supported on BSD or Solaris, the dropdown behaves as explained in comment 4
https://addons.allizom.org/z/en-US/developers/addon/compact-menu-2/versions/118338

Comment 8

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 9

[krupa raj[:krupa]]

Attachment: post-fix screenshot