amo-validator: filenames in nested jar show up as numbers

VERIFIED FIXED in 5.12.7

Status

addons.mozilla.org Graveyard
Developer Pages
P3
normal
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: kumar, Assigned: basta)

Tracking

unspecified
5.12.7

Details

Attachments

(1 attachment)

Created attachment 500429 [details]
delicious bookmarks addon

STR
- upload/validate the attached delicious addon

Notice the 2nd error in the Localization Tests having the header "Global called in dangerous manner"

The affected file is reported as:
chrome/deliciousbookmarks.jar/0

but I'd expect:
chrome/deliciousbookmarks.jar/options.js

In the validator JSON this looks like:
{
    ...
    "file": ["chrome/deliciousbookmarks.jar", "0"]
}
Assignee: nobody → mbasta
note also that the reported line number of the error in options.js is incorrect (probably related)
Target Milestone: --- → 5.12.7
Priority: -- → P3
(Assignee)

Comment 2

8 years ago
Fixed:

https://github.com/mattbasta/amo-validator/commit/48a4e6a901f6a70ccfa34e746ba32a626ea9ffb7

For the line numbers, everything looks fine on my end. Perhaps the fix also fixed the line numbers? Keep in mind that the line number is 1-based, not 0-based. Column (position) numbers should be 0-based. Also, the line number returned in the JSON represents the line of the middle line of the context.
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
STR is no longer showing the "0" as part of the filename.  Thanks!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.