622207 - amo-validator: filenames in nested jar show up as numbers

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Kumar McMillan [:kumar]]

Attachment: delicious bookmarks addon

STR
- upload/validate the attached delicious addon

Notice the 2nd error in the Localization Tests having the header "Global called in dangerous manner"

The affected file is reported as:
chrome/deliciousbookmarks.jar/0

but I'd expect:
chrome/deliciousbookmarks.jar/options.js

In the validator JSON this looks like:
{
    ...
    "file": ["chrome/deliciousbookmarks.jar", "0"]
}

Comment 1

[Kumar McMillan [:kumar]]

note also that the reported line number of the error in options.js is incorrect (probably related)

Comment 2

[Matt Basta [:basta]]

Fixed:

https://github.com/mattbasta/amo-validator/commit/48a4e6a901f6a70ccfa34e746ba32a626ea9ffb7

For the line numbers, everything looks fine on my end. Perhaps the fix also fixed the line numbers? Keep in mind that the line number is 1-based, not 0-based. Column (position) numbers should be 0-based. Also, the line number returned in the JSON represents the line of the middle line of the context.

Comment 3

[Kumar McMillan [:kumar]]

STR is no longer showing the "0" as part of the filename.  Thanks!