622220 - --setpref's are stomped by jsbrowsertest

Status: RESOLVED WONTFIX

(Testing :: Reftest, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

For bug 615386, I'm adding a jsbrowsertest-ipc target by running jsbrowsertest with --setpref=browser.tabs.remote=true.  This fails because jsbrowsertest copies a custom user.js into the profile *after* the --setpref's are processed, meaning those args get stomped.

Upcoming patch processes --setprefs after copying extra files.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Process --setpref's after copying extra files

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Process --setpref's after copying extra files

Comment in v1 was extremely confusing.  Trying again.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 500458 [details] [diff] [review]
Process --setpref's after copying extra files

Thanks for the patch Chris.  We need to do a followup patch for the remote testing since after profile creation, we copy the profile to the device we are testing.  I can get to that this weekend when I get access to my device for a sanity check.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: after setting prefs in profile, copy to device (1.0)

patch to make this work with the remote testing stuff.  Not sure if the IPC work referenced will work, but at least the profile editing will!

Comment 5

[cmtalbert]

Comment on attachment 500789 [details] [diff] [review]
after setting prefs in profile, copy to device (1.0)

This looks good.  Chris or Joel, whichever of you lands this, let's land both patches simultaneously so we can keep our remote-testing setup in sync with the non-remote testing setup.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I don't think this is relevant anymore.