622553 - Tap Highlighting blue glow CSS fixes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch does some polish for the blue glow highlight:
 * Limit the size of the rect for Select element (regression from bug 621730)
 * Do not change the style of checkbox/radio for disabled elements on a mouseover
 * Do not create a blue rect for disabled elements

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 500803 [details] [diff] [review]
Patch


>-  if (blockDisplays.indexOf(computedStyle.getPropertyValue("display")) != -1 &&
>-      computedStyle.getPropertyValue("overflow") == "hidden")
>+  if ((blockDisplays.indexOf(computedStyle.getPropertyValue("display")) != -1 &&
>+      computedStyle.getPropertyValue("overflow") == "hidden") || aElement instanceof HTMLSelectElement)

Can you put this on one line? I'm too old to follow the groups with it split like this

>-        if (targetElement) {
>+        let isDisabled = targetElement instanceof HTMLOptionElement ? (targetElement.disabled || targetElement.parentNode.disabled)
>+                                                                    : targetElement.disabled;

What if targetElement is null? We check for that below.

r- for the targetElement issue

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Addressed comments

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/22af6f29b684

Comment 4

[Dão Gottwald [:dao]]

bugspam