Closed Bug 622553 Opened 9 years ago Closed 9 years ago

Tap Highlighting blue glow CSS fixes

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
This patch does some polish for the blue glow highlight:
 * Limit the size of the rect for Select element (regression from bug 621730)
 * Do not change the style of checkbox/radio for disabled elements on a mouseover
 * Do not create a blue rect for disabled elements
Attachment #500803 - Flags: review?(mark.finkle)
Comment on attachment 500803 [details] [diff] [review]
Patch


>-  if (blockDisplays.indexOf(computedStyle.getPropertyValue("display")) != -1 &&
>-      computedStyle.getPropertyValue("overflow") == "hidden")
>+  if ((blockDisplays.indexOf(computedStyle.getPropertyValue("display")) != -1 &&
>+      computedStyle.getPropertyValue("overflow") == "hidden") || aElement instanceof HTMLSelectElement)

Can you put this on one line? I'm too old to follow the groups with it split like this

>-        if (targetElement) {
>+        let isDisabled = targetElement instanceof HTMLOptionElement ? (targetElement.disabled || targetElement.parentNode.disabled)
>+                                                                    : targetElement.disabled;

What if targetElement is null? We check for that below.

r- for the targetElement issue
Attachment #500803 - Flags: review?(mark.finkle) → review-
Attached patch Patch v0.2Splinter Review
Addressed comments
Attachment #500803 - Attachment is obsolete: true
Attachment #500819 - Flags: review?(mark.finkle)
Attachment #500819 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/22af6f29b684
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.