Closed
Bug 622594
Opened 15 years ago
Closed 15 years ago
Remove _options (OptionsClass) as a browser builtin
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: cdleary, Assigned: cdleary)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
4.35 KB,
patch
|
Details | Diff | Splinter Review |
From a Web Console session:
[02:49:05.926] _options
[02:49:05.930] ({strict:false, werror:false, relimit:false})
This ties into the OptionsClass in nsJSEnvironment.cpp.
|
Assignee | |
Comment 1•15 years ago
|
||
If this is a simple ripping-out I can easily incorporate it into my patch set for bug 595691.
|
|
||
Comment 2•15 years ago
|
||
Johnny, Jonas, any objections? I think we should nuke this thing.
|
||
Comment 3•15 years ago
|
||
Agreed.
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → cdleary
|
|
Assignee | |
Comment 4•15 years ago
|
||
This was green on try ( http://hg.mozilla.org/try/rev/c805f06a4720 ), and I'm probably going to need to remove the weird "defer to options object" bit for the auto version API fix in bug 595691.
Attachment #505701 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 505701 [details] [diff] [review]
Delete _options object.
Canceling review, will happen in the version fix bug.
Attachment #505701 -
Flags: review?(mrbkap)
|
|
Assignee | |
Comment 6•15 years ago
|
||
Fixed in tracemonkey per bug 595691 comment 34.
Status: NEW → ASSIGNED
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•15 years ago
|
||
|
||
Updated•13 years ago
|
Component: DOM: Other → DOM
|
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•