622602 - Unicode blocks screenshot saving

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Jeff Balogh (:jbalogh)]

There's unicode in the de captions for 1865, so I can't save any screenshots.

https://addons.allizom.org/z/en-US/developers/addon/adblock-plus/edit

[10:02:15.695] uncaught exception: [Exception... "String contains an invalid character"  code: "5" nsresult: "0x80530005 (NS_ERROR_DOM_INVALID_CHARACTER_ERR)"  location: "https://addons.allizom.org/media/js/zamboni/devhub-min.js?build=b3ac652 Line: 1"]

Comment 2

[Potch [:potch]]

Are there any STR for me locally?

Comment 3

[Jeff Balogh (:jbalogh)]

(In reply to comment #2)
> Are there any STR for me locally?

bug 622743 comment 0.

xhr.sendAsBinary busts its head if it sees unicode. I did a quick googling with bug 621582 and the results did not look promising, so I decided the easy fix was to remove the piece that was injecting unicode.

The quick fix here might be to send two requests, one for the images and one for the captions. That's more efficient if none of the images change anyway.  Even better would be to stop all this manual multipart nonsense and use something smoother (but I don't know if that's possible).

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

STR locally - edit Ad Block Plus.

Comment 5

[Gregory Koberger (:gkoberger)]

jbalogh - I've already started to change the way we do it; I think icons is the only one I still have to convert over.  I upload the image using send() and save it as a temp file, and then copy it over once the user hits 'Save'.  This should fix all the unicode issues, since the form can be submitted without having to do manual multipart javascript.

Comment 6

[Gregory Koberger (:gkoberger)]

https://github.com/jbalogh/zamboni/commit/d9550764eb17966c0c50eccc9b3ea5f5a09319b5

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED: Saving with Unicode is now fine (यह लोग हिन्दी क्यों नहीं बोल सकते हैं)

Comment 8

[krupa raj[:krupa]]

(In reply to comment #7)
> Verified FIXED: Saving with Unicode is now fine (यह लोग हिन्दी क्यों नहीं बोल
> सकते हैं)

your test data is hilarious!