622656 - Add-on Builder Helper appears to be broken for Mac OS X

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect, P1)

Description

[Daniel Buchner [:dbuc]]

Attempting to use the ABH in the latest beta or Minefield versions of Fx on Mac OS X, there is something breaking inside the ABH that prevents it from creating the appropriate config prefs for the trusted domain. If you install and manually add the pref, the add-on operates just fine.

Comment 1

[Daniel Buchner [:dbuc]]

Ayan has also confirmed this is an issue for Linux as well.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

What are the "appropriate config prefs" that ABH fails to create?

Comment 3

[Daniel Buchner [:dbuc]]

The ABH uses the trustedOrigins object in the lib dirs js file to create this config entry: extensions.addonBuilderHelper.trustedOrigins

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Hmm, my reading of the code is that it doesn't actually create that entry itself, it just reads it if it exists.  Without the entry, the list of trusted domains is exactly the list that ships with ABH (in its data/addon-config.json directory).  With the entry, the list of trusted domains is the list that ships with ABH along with any additional entries in that preference.

What server are you testing on?  If it's on https://builder-addons-next.allizom.org, then that would explain the problem, since that site isn't in the list of trusted domains in data/addon-config.json.  If that's the problem, then adding that URL to the list should sufficient to resolve it.

Comment 5

[Daniel Buchner [:dbuc]]

I believe Ayan and I tested it on all the various domain variants the app was on, I will double check and post back here.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Attachment: candidate build

Here's a candidate build that I think solves the problems.

Ayan, Daniel: can you test and confirm whether or not it actually does solve the problems?

Comment 7

[Daniel Buchner [:dbuc]]

I can try it, but I never had the issue in Windows. Ayan, can you give this a spin?

Comment 8

[Ayan Shah[:ashah]]

myk: yes it works for me now. I tried it on beta8 on the live as well as the stage website.Thanks!

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Ok, I have uploaded the new version to AMO, where it should appear after it gets review.

Comment 10

[Daniel Buchner [:dbuc]]

Thank you for that Myk!