622687 - Validator fails with false-negative error about "Missing translation files"

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: test file

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13

steps to reproduce:
1. Upload the test file(copied from download statusbar)

observed behavior:
Validation fails with-

Error: Localizations must include a translated copy of each file in the reference locale. The required files may vary from target application to target application.

The add-on is not missing any translation files.

Comment 1

[Wil Clouser [:clouserw]]

(In reply to comment #0)

> The add-on is not missing any translation files.

If that's the case, this is a bug, but keep in mind, missing L10n is not an error anyway.  At best it's a warning under the L10n tier.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

A missing translation file should be an error because it would break Firefox for the incomplete locale, and that's something that is hard to detect for editors. However, a warning is good enough because editors will always read them when reviewing an add-on and can confirm by looking at the code.

I looked at this earlier with krupa and it did appear to be a bug because there was an error message for every locale file in the add-on, and the package appears to be complete.

Comment 3

[Matt Basta [:basta]]

I have a fix for this issue, however, my tests are now failing. I'm going to do some more work to investigate whether it's my tests or if it's my code.

Comment 4

[Matt Basta [:basta]]

Fixed:

https://github.com/mattbasta/amo-validator/commit/3e7f233ffe3b0310fc0049043db257daf0af82c0

Note that the add-on also has quite a few missing translation entities. It appears to be incorrectly reporting that just about every locale contains missing entities, however, I have verified that this is accurate.

Comment 5

[Kumar McMillan [:kumar]]

After this commit I see these test failures in amo-validator: http://pastebin.mozilla.org/911093

is everything passing for you?

Comment 6

[Matt Basta [:basta]]

Kumar: I've got a separate commit with a bunch of updates to unit tests in the works. They're all tied together; there's updates to the helper module that broke a bunch of tests. I'll push them out tonight. I'm trying to get as much tied up as I can. I'll post a link to the commit here once I get it out.

Comment 7

[krupa raj[:krupa]]

(In reply to comment #6)
>  I'll post a link to the commit here once I get it out.

Has this commit landed?

Comment 8

[Matt Basta [:basta]]

I believe it has. Kumar has pushed newer commits; this was rolled up in other bugs which were already verified. It should be ready to verify.

Comment 9

[krupa raj[:krupa]]

verified fixed