622799 - [tinder][dashtags] fix existing tests, add tests for tags and filters

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P1)

Description

[Axel Hecht [:Pike]]

The existing tests for the tinder app in django_site don't work no more, doh.

I also wanted tests for our tags and filters in preparation for the django update.

There's one "ugh" in this patch, and that's a disabled "test" to export the waterfall display to local files for the used closures. That helps in debugging those tests. Not sure if there'd be a better solution for that?

Comment 1

[Axel Hecht [:Pike]]

Attachment: fix existing tests, add new tests for filters and tags.

Comment 2

[Staś Małolepszy :stas]

Attachment: Same patch with tindertest mgmt command added

Before I review your patch, here's my take on the 'ugh' part. I propose that we add a 'tindertest' management command which normally behaves like the regular 'test', but can be passed a --with-waterfall option which will make it run the 3 problematic testcases. What do you think? This could be extended to more testcases if you need it and possibly moved away from tinder.

Comment 3

[Peter Bengtsson [:peterbe]]

This patch has now been integrated into the playdoh-reorg branch in git

https://github.com/mozilla/elmo/commit/d5a5528f623be9104d14666fffe4bcae4889cf7a
and
https://github.com/mozilla/elmo/commit/a6e66dd63386878bc869a29d63f421d7013fe472

Comment 4

[Axel Hecht [:Pike]]

We landed the non-if version of this without the management command in https://github.com/mozilla/elmo/commit/f9852d580c1cc28a448e1bfb6cfb178b063d8e35, which will land as part of the playdoh branch.

Filed bug 653377 to get a good way to render fixtures to disk.

Resolving FIXED, a tad early, but we're in sprint mode.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 500992 [details] [diff] [review]
fix existing tests, add new tests for filters and tags.

Clearing reviews, this bug is FIXED.