[tinder][dashtags] fix existing tests, add tests for tags and filters

RESOLVED FIXED in 1.2

Status

P1
normal
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
The existing tests for the tinder app in django_site don't work no more, doh.

I also wanted tests for our tags and filters in preparation for the django update.

There's one "ugh" in this patch, and that's a disabled "test" to export the waterfall display to local files for the used closures. That helps in debugging those tests. Not sure if there'd be a better solution for that?
(Assignee)

Comment 1

8 years ago
Created attachment 500992 [details] [diff] [review]
fix existing tests, add new tests for filters and tags.
Attachment #500992 - Flags: review?(stas)
Created attachment 503294 [details] [diff] [review]
Same patch with tindertest mgmt command added

Before I review your patch, here's my take on the 'ugh' part. I propose that we add a 'tindertest' management command which normally behaves like the regular 'test', but can be passed a --with-waterfall option which will make it run the 3 problematic testcases. What do you think? This could be extended to more testcases if you need it and possibly moved away from tinder.
Attachment #503294 - Flags: feedback?(l10n)
(Assignee)

Updated

7 years ago
Component: Infrastructure → Elmo
Product: Mozilla Localizations → Webtools
QA Contact: infrastructure → elmo
Summary: [dashboard][tinder][dashtags] fix existing tests, add tests for tags and filters → [tinder][dashtags] fix existing tests, add tests for tags and filters
Version: unspecified → 1.0

Updated

7 years ago
Priority: P2 → P1
Target Milestone: --- → 1.2
(Assignee)

Comment 4

7 years ago
We landed the non-if version of this without the management command in https://github.com/mozilla/elmo/commit/f9852d580c1cc28a448e1bfb6cfb178b063d8e35, which will land as part of the playdoh branch.

Filed bug 653377 to get a good way to render fixtures to disk.

Resolving FIXED, a tad early, but we're in sprint mode.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

7 years ago
Comment on attachment 500992 [details] [diff] [review]
fix existing tests, add new tests for filters and tags.

Clearing reviews, this bug is FIXED.
Attachment #500992 - Flags: review?(stas)
(Assignee)

Updated

7 years ago
Attachment #503294 - Flags: feedback?(l10n)
You need to log in before you can comment on or make changes to this bug.