622905 - Changing compatibility info for an add-on affects the review status

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Choose an add-on which is prelim-reviewed.
2. Update its compatibility info(either firefox version or supported OS)
3. Save changes
4. Notice the status of the add-on in /versions page

observed behavior:
On changing the compatibility info of an add-on, the add-on is moved back to awaiting-preliminary review queue.

screencast: http://screencast.com/t/pM0rUiH9

Comment 1

[Andy McKay]

Note for self. This is because the version changed, which triggered update_status, which found there are no public files and changed the status back. Perhaps this is the right moment to nuke update status on changing a version.

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to comment #1)
> Note for self. This is because the version changed, which triggered
> update_status, which found there are no public files and changed the status
> back. Perhaps this is the right moment to nuke update status on changing a
> version.

Was the add-on in an improper state? Should this happen in real life?

Comment 3

[Andy McKay]

I believe so. Files and Addon are in prelimnary reviewed and awaiting full review. No files are public yet.

Comment 4

[Andy McKay]

This is related to 569949. After a chat with jorgev we came up with:

a) we should only be changing the status to incomplete if the add-on is public

b) if the addon is public and there are no public versions left then:

- if there's a version with preliminary approval, change status to preliminary approval

- otherwise change to incomplete

Comment 5

[Andy McKay]

https://github.com/jbalogh/zamboni/commit/46028d681db5608a697f0db9b3b127198ab68bdb