623062 - When USB storage is enabled, Fennec fails to start.

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

When USB storage is enabled, Fennec fails to start.  I may have moved Fennec to the SD Card at one point, but it no longer is on the SD Card.

Comment 1

[Doug Turner (:dougt)]

E/AndroidRuntime(23955): FATAL EXCEPTION: Thread-9
E/AndroidRuntime(23955): java.lang.NullPointerException
E/AndroidRuntime(23955): 	at org.mozilla.gecko.GeckoAppShell.loadGeckoLibs(GeckoAppShell.java:138)
E/AndroidRuntime(23955): 	at org.mozilla.gecko.GeckoApp$3.run(GeckoApp.java:196)
E/AndroidRuntime(23955): 	at java.lang.Thread.run(Thread.java:1096)


http://mxr.mozilla.org/mozilla-central/source/embedding/android/GeckoAppShell.java#137

need to catch that and have a fallback.

Comment 2

[Doug Turner (:dougt)]

mbrubeck, blassey, what should we do here?  If the variable is left unset, the exist callers handle it.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

You could use a string instead of a File:

String downloadDir = null;
        if (Build.VERSION.SDK_INT >= 8)
            downloadDir = GeckoApp.mAppContext.getExternalFilesDir(Environment.DIRECTORY_DOWNLOADS).getPath();
        else
            downloadDir = Environment.getExternalStorageDirectory().getPath() + File.separator +"download";
        GeckoAppShell.putenv("DOWNLOADS_DIRECTORY=" + downloadDir);

also have a look here: https://mxr.mozilla.org/mozilla-central/source/embedding/android/GeckoApp.java#430

I assume this isn't a problem on froyo, right?

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 502656 [details] [diff] [review]
patch v.1

mbrubeck and mwu had some good idea (well, serious concerns) over keeping this stale data around.  For example, if the user starts up with a sd card mounted, launches fennec, then unmounts the sdcard.

For these cases, it is best that we do not store the downloads directory location at all, and instead query for it each and every time.

If a download is in progress, I think the notification that the user receives when mounting the sdcard is sufficient.

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 502656 [details] [diff] [review]
patch v.1

I'd be fine with checking this in a quick fix for now, and fixing the rest in a followup bug.  Or if you just want to post a new patch that fixes it the "right" way, go ahead.

Comment 7

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/8787080c9771

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

Was there a followup bug filed for comment 6?

Moved Firefox Mobile to then from the SD card and Firefox started with usb storage enabled. Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20110315 Firefox/4.0b13pre Fennec/4.0b6pre ID:20110315035936