exception_raise_state exception_raise_state_identity have Duplicated parameter name thread_state_count

RESOLVED FIXED in mozilla2.0b10

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

Trunk
mozilla2.0b10
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 501235 [details] [diff] [review]
Rename duplicates

There are sum functions declared with duplicated parameters name. That is not valid c++. See "Parameter name lookup" in http://clang.llvm.org/compatibility.html#c++
Attachment #501235 - Attachment is patch: true
Attachment #501235 - Attachment mime type: application/octet-stream → text/plain
Attachment #501235 - Flags: review?(ted.mielczarek)

Comment 1

8 years ago
The reporter's summary and initial comment were both lame. I'm merely adjusting the summary and providing a better link. I am not passing judgement on the quality of the bug report.

http://clang.llvm.org/compatibility.html#param_name_lookup
Summary: Duplicated parameter name → exception_raise_state exception_raise_state_identity have Duplicated parameter name thread_state_count

Comment 2

8 years ago
Comment on attachment 501235 [details] [diff] [review]
Rename duplicates

one's an out variable, either they should use a polish notation or an out indicator, this is the wrong fix.
Attachment #501235 - Flags: review?(ted.mielczarek) → review-
Sorry, I am not sure that I follow. This is not a style question. The code is invalid c++. I will upstream the patch if it is already not there, but really need to rename of the arguments.
He's saying (and I agree), that your chosen replacement names kind of suck, that's all. I can land these patches upstream for you once we get them all reviewed.
Assignee: nobody → respindola
Created attachment 501326 [details] [diff] [review]
copy of the patch sent upsteram
Attachment #501326 - Flags: review?
Attachment #501326 - Flags: review? → review?(ted.mielczarek)
Comment on attachment 501326 [details] [diff] [review]
copy of the patch sent upsteram

r+ed upstream as well. I'll coordinate landing all these in a bit.
Attachment #501326 - Flags: review?(ted.mielczarek) → review+

Updated

8 years ago
Attachment #501326 - Flags: approval2.0?

Updated

8 years ago
Attachment #501326 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed

Comment 9

8 years ago
http://hg.mozilla.org/mozilla-central/rev/3915ec30a832
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
You need to log in before you can comment on or make changes to this bug.