623132 - Add constructor for nsCaseInsensitiveCStringComparator (which inherits from nsCStringComparator) to placate CLang

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

nsCaseInsensitiveCStringComparator is missing a user defined constructor,
but in mozStorageStatement.cpp a const variable of this type is defined.

This is not valid c++. For more information see "Default initialization of
const variable of a class type requires user-defined default constructor" in
http://clang.llvm.org/compatibility.html#c++

Comment 1

[timeless]

The reporter's summary and initial comment were both lame. I'm merely adjusting the summary and providing a better link. I am not passing judgement on the quality of the bug report.

http://clang.llvm.org/compatibility.html#default_init_const

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 501257 [details] [diff] [review]
patch

I have the same question as in bug 623116 comment 3, but anyway bsmedberg should review in XPCOM.

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b26e0f9e43e8