Add constructor for nsCaseInsensitiveCStringComparator (which inherits from nsCStringComparator) to placate CLang

RESOLVED FIXED in mozilla5

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

Trunk
mozilla5
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
nsCaseInsensitiveCStringComparator is missing a user defined constructor,
but in mozStorageStatement.cpp a const variable of this type is defined.

This is not valid c++. For more information see "Default initialization of
const variable of a class type requires user-defined default constructor" in
http://clang.llvm.org/compatibility.html#c++
Attachment #501257 - Attachment is patch: true
Attachment #501257 - Attachment mime type: application/octet-stream → text/plain
Attachment #501257 - Flags: review?(smontagu)

Comment 1

9 years ago
The reporter's summary and initial comment were both lame. I'm merely adjusting the summary and providing a better link. I am not passing judgement on the quality of the bug report.

http://clang.llvm.org/compatibility.html#default_init_const
Summary: Missing constructor → Add constructor for nsCaseInsensitiveCStringComparator (which inherits from nsCStringComparator) to placate CLang
Comment on attachment 501257 [details] [diff] [review]
patch

I have the same question as in bug 623116 comment 3, but anyway bsmedberg should review in XPCOM.
Attachment #501257 - Flags: review?(smontagu) → review?(benjamin)

Updated

8 years ago
Attachment #501257 - Flags: review?(benjamin) → review+

Updated

8 years ago
Assignee: nobody → respindola
Depends on: post2.0

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/b26e0f9e43e8
Status: NEW → RESOLVED
Last Resolved: 8 years ago
No longer depends on: post2.0
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.