623144 - Stop Using This Account (startOver) should clear error notification still shown

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Comment 1

[Mike Connor [:mconnor]]

one-liner to add Notifications.removeAll() ?

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 504318 [details] [diff] [review]
v1

Do we want to do this here, or in the service?  We should be able to call it from the service...

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to comment #3)
> Do we want to do this here, or in the service?  We should be able to call it
> from the service...

So I was looking at this and and first thought about putting it in the service, but then I noticed how we have a nice separation between the service and all UI driving code (through observer notifications). I would like to keep it that way. That way we can also give that notifications code a comb-over (which it'll need to be less spammy, for instance) without touching service.

tl;dr: preserving neat logic vs. UI code separation that we already have.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 504318 [details] [diff] [review]
v1

Okay, good enough for now.  We need to fix notifications to not be a disaster, but that can be post Fx4.

Comment 6

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/82544a4cfb63