623153 - When pattern and multiple are specified, pattern should apply to all tokens

Status: NEW

(Core :: DOM: Core & HTML, defect, P3)

Description

[Mounir Lamouri (:mounir)]

For example:
<input type='email' pattern='[^@]*@company.com' multiple>

Currently, this value is valid:
"[e-mail]"
but not this one:
"[e-mail], [e-mail]"

Both should be valid.

This bug reflects a recent change in WHAT WG HTML5 specs (r5738).

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Apply pattern to every token for input type="email" multiple

I'm not really sure about using nsDependentSubstring instead of a string type that owns its buffer. Let me know if you think I should do more research on it. Thank you.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Test case

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 8388197 [details] [diff] [review]
Apply pattern to every token for input type="email" multiple

Review of attachment 8388197 [details] [diff] [review]:
-----------------------------------------------------------------

What about having a ::GetValues() method that will return the "values" as described in the specification. Then, we could simply run the pattern check on all the different item. The advantage of that approach is that we could then expand it to all types of <input> that have @multiple applying to them.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Sounds good. Can I have this bug assigned while I'm working on it? Thanks

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Apply pattern to every token for input type="email" multiple

Let me know if you prefer not to change IsValidEmailAddress. Thank you.

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: multipleInput.patch

Polished some whitespace change.

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

Comment on attachment 8391919 [details] [diff] [review]
multipleInput.patch

Review of attachment 8391919 [details] [diff] [review]:
-----------------------------------------------------------------

I'm sorry, I just noticed that doing this creates inconsistencies between multiple and non-multiple email checking, in the non-multiple case spaces are not trimmed before checking so " [e-mail]" is not valid, while in the multiple case it is. Also it allows non-multiple input elements to have more than one email specified (I'll fix this soon). Maybe a partial fix for 805039 would help this?

Comment 8

[Marion Daly [:mdaly]]

Overholt: patch has been sitting here awhile, should probably have someone look at it.

Comment 9

[Andrew Overholt [:overholt]]

Agi, are you still working on this?

Comment 10

[Andrew Overholt [:overholt]]

Oops, sorry, Mounir!

Comment 11

[[ex-Mozilla] Agi Sferro | :agi]

No, sorry for keeping it assigned!

Comment 12

[Timothy Gu [:TimothyGu]]

Tests for this have been added to WPT in https://github.com/web-platform-tests/wpt/pull/21060.