623182 - Add id to the input for search to help with testability

Status: RESOLVED WONTFIX

(support.mozilla.org :: Search, defect)

Description

[David Burns :automatedtester]

The snippet below has an input that is used a lot by Selenium but doesnt have an id so when it changes from <button> to <input> or has its css class changed the Selenium tests start failing.

Please add an id to this.

<div role="search" id="support-search" class="support-search">
        <form method="get" action="/en-US/search">
      <span class="wrap">
        <input type="text" required="required" placeholder="Search Firefox Help" name="q" class="text">
      </span>
      <input type="image" alt="Search" title="Search" src="/media/img/btn.search.png" class="submit">
    </form>
  </div>

Thanks

Comment 1

[James Socol [:jsocol, :james]]

For the record, which <input> are you talking about, the submit or the text?

Comment 2

[David Burns :automatedtester]

doh, I only noticed one of them.

The submit to have an id please

Comment 3

[James Socol [:jsocol, :james]]

Is this still necessary? "div#support-search input.submit" should uniquely identify the input.

The search box code is in a Jinja2 macro[1] so adding an ID without accidentally adding duplicate IDs means doing some gymnastics or touching every call site for the macro--we did that, for example, when we added 'id="support-search"'.

[1] https://github.com/mozilla/kitsune/blob/master/templates/includes/common_macros.html#L2

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Haven't heard anything from the original poster, so ... I'm closing this out.