Closed Bug 623186 Opened 13 years ago Closed 13 years ago

Old updater window is invoked when clicking "Apply Update" in about window

Categories

(Toolkit :: Application Update, defect)

defect
Not set
normal

Tracking

()

VERIFIED INVALID

People

(Reporter: whimboo, Unassigned)

References

()

Details

Today I was using one of our old Mozmill boxes and updated a 4.0b8pre version to the latest 4.0b9pre one. Doing that from inside the about window, and clicking on "Apply Update", the old Software Update interface popped-up. I was forced to download the update again.

Not sure if that happens because of that one extension is not compatible with b9 yet and we do not have a replacement UI? The current behavior is kinda confusing. See the screencast: http://screencast.com/t/dNNtqzcO
Asking for blocking because the update system is a key part for offering new versions of Firefox and it should have clear steps in all possible cases.
blocking2.0: --- → ?
Also a situation like that would kill our automated Mozmill tests, because it's an unexpected behavior. But as long as we do not have any add-on installed, we should hopefully be ok.
This is caused by the add-on not being compatible. What behavior do you think it should have when an add-on is not compatible?
Per bug 596813 comment #18 which specifies the behavior for this ui this is by design. Resolving -> invalid.

A couple of ways you can can fix this is by either making the mozmill tests capable of handling the different paths in the ui an update can take, make the mozmill add-on compatible, or install the mozmill add-on into the app dir since we don't check add-ons in that location. Note: Mossop and I have talked about not allowing extension installation into the app dir in the future but that isn't even on the drawing board yet.
Status: NEW → RESOLVED
blocking2.0: ? → ---
Closed: 13 years ago
Resolution: --- → INVALID
Reading the referenced specs shows me a different behavior as what we have right now. Here a quote:

// S3: Add-on compatibility problems

 Minefield
 4.0b7pre (released 09-15-2010)
 [ Apply Update...]

 --> this brings up the update UI to show which add-ons are incompatible and
determine if the user wants to continue. The user has two options in this UI,
either to continue with the update or to cancel.

Cancel should bring the user back to S3
Continue should bring the user to S4

// S4: Minor update downloading

 Minefield
 4.0b7pre (released 09-15-2010)
 @ Downloading update — 879 KB of 2.1 MB

--> if the partial update fails, just automatically start downloading the full
update, no need to notify the user
--> if there is a problem in the download, skip to S6


In step 3 when clicking on "Continue" we should at least close the old updater and further process in the about window. Or have I miss-understood something?
OS: Mac OS X → All
Once the app update window is open it is to be used to update.

Also, I brought up closing the about window in comment #19 and beltzner stated whatever is easiest in comment #20.
Thanks Rob.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.