Virtualenv cannot execute binaries if the path to the environment includes spaces

RESOLVED FIXED in 0.1

Status

Mozilla QA Graveyard
Mozmill Crowd Extension
--
major
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: aaronmt, Assigned: whimboo)

Tracking

unspecified

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
Currently the environment will be downloaded but not deployed on profiles with spaces in-between, such as "~/.mozilla/firefox/vghhdjde.Default User/". The environment will be downloaded but not deployed to a bin folder.
(Reporter)

Updated

7 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Updated

7 years ago
Severity: normal → major
(Reporter)

Updated

7 years ago
Target Milestone: --- → 0.1
(Assignee)

Updated

7 years ago
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
(Assignee)

Comment 1

7 years ago
Ok, so the reason here is, that the scripts installed by virtualenv cannot be executed if the path to itself contains spaces. This is kinda awkward and there is no workaround. See the following URL:

http://www.mail-archive.com/bug-bash@gnu.org/msg03972.html

The only way we can circumvent this problem is to only allow paths, which do not contain a space. That can be done by using an open dialog. It would affect each OS. Means the user has to manually select a folder, which will be used as storage.
Summary: Environment downloaded but not deployed on profiles with spaces → Virtualenv cannot execute binaries if the path to the environment includes spaces
(Assignee)

Comment 2

7 years ago
Created attachment 501642 [details] [diff] [review]
Patch v1

This patch now makes use of a pref which holds the current location of the storage. Also the user is not allowed to select a folder which has a space in its path. I have also cleaned-up some of the properties which aren't in use anymore.
Attachment #501642 - Flags: review?(aaron.train)
(Reporter)

Comment 3

7 years ago
Comment on attachment 501642 [details] [diff] [review]
Patch v1

>+storage.path_not_found=The folder, which is used to store all extension related files, cannot be found. Please select a new one.
>+storage.path_has_space=Due to limitations we currently do not support folders with a space in the path. Please select a new one.

Nit: "The folder which is used to store all extension related files can not be found. Please select a new one."
Nit: "Due to limitations, we currently do not support folders with a space in the path. Please select a new one."

Other than that, everything is OK.
Attachment #501642 - Flags: review?(aaron.train) → review-
(Assignee)

Comment 4

7 years ago
Created attachment 501787 [details] [diff] [review]
Patch v2.0

Thanks. Reasking for review, because no carry-over has been mentioned.
Attachment #501642 - Attachment is obsolete: true
Attachment #501787 - Flags: review?(aaron.train)
(Assignee)

Comment 5

7 years ago
Created attachment 501800 [details] [diff] [review]
Patch v2.1

Fixes the wrapping issue introduced by c&p the text from Bugzilla.
Attachment #501787 - Attachment is obsolete: true
Attachment #501800 - Flags: review?(aaron.train)
Attachment #501787 - Flags: review?(aaron.train)
(Reporter)

Updated

7 years ago
Attachment #501800 - Flags: review?(aaron.train) → review+
(Assignee)

Comment 6

7 years ago
Landed as:
https://github.com/whimboo/mozmill-crowd/commit/61ba3d5c41434bffb0cce43b65bc5d57a7da461f
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.