Closed
Bug 623224
Opened 14 years ago
Closed 14 years ago
Virtualenv cannot execute binaries if the path to the environment includes spaces
Categories
(Mozilla QA Graveyard :: Mozmill Crowd Extension, defect)
Mozilla QA Graveyard
Mozmill Crowd Extension
Tracking
(Not tracked)
RESOLVED
FIXED
0.1
People
(Reporter: aaronmt, Assigned: whimboo)
References
()
Details
Attachments
(1 file, 2 obsolete files)
7.43 KB,
patch
|
aaronmt
:
review+
|
Details | Diff | Splinter Review |
Currently the environment will be downloaded but not deployed on profiles with spaces in-between, such as "~/.mozilla/firefox/vghhdjde.Default User/". The environment will be downloaded but not deployed to a bin folder.
Reporter | ||
Updated•14 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Reporter | ||
Updated•14 years ago
|
Severity: normal → major
Reporter | ||
Updated•14 years ago
|
Target Milestone: --- → 0.1
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
Ok, so the reason here is, that the scripts installed by virtualenv cannot be executed if the path to itself contains spaces. This is kinda awkward and there is no workaround. See the following URL: http://www.mail-archive.com/bug-bash@gnu.org/msg03972.html The only way we can circumvent this problem is to only allow paths, which do not contain a space. That can be done by using an open dialog. It would affect each OS. Means the user has to manually select a folder, which will be used as storage.
Summary: Environment downloaded but not deployed on profiles with spaces → Virtualenv cannot execute binaries if the path to the environment includes spaces
Assignee | ||
Comment 2•14 years ago
|
||
This patch now makes use of a pref which holds the current location of the storage. Also the user is not allowed to select a folder which has a space in its path. I have also cleaned-up some of the properties which aren't in use anymore.
Attachment #501642 -
Flags: review?(aaron.train)
Reporter | ||
Comment 3•14 years ago
|
||
Comment on attachment 501642 [details] [diff] [review] Patch v1 >+storage.path_not_found=The folder, which is used to store all extension related files, cannot be found. Please select a new one. >+storage.path_has_space=Due to limitations we currently do not support folders with a space in the path. Please select a new one. Nit: "The folder which is used to store all extension related files can not be found. Please select a new one." Nit: "Due to limitations, we currently do not support folders with a space in the path. Please select a new one." Other than that, everything is OK.
Attachment #501642 -
Flags: review?(aaron.train) → review-
Assignee | ||
Comment 4•14 years ago
|
||
Thanks. Reasking for review, because no carry-over has been mentioned.
Attachment #501642 -
Attachment is obsolete: true
Attachment #501787 -
Flags: review?(aaron.train)
Assignee | ||
Comment 5•14 years ago
|
||
Fixes the wrapping issue introduced by c&p the text from Bugzilla.
Attachment #501787 -
Attachment is obsolete: true
Attachment #501800 -
Flags: review?(aaron.train)
Attachment #501787 -
Flags: review?(aaron.train)
Reporter | ||
Updated•14 years ago
|
Attachment #501800 -
Flags: review?(aaron.train) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Landed as: https://github.com/whimboo/mozmill-crowd/commit/61ba3d5c41434bffb0cce43b65bc5d57a7da461f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•