If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

AsymmGC - Thread-safe PageMap

NEW
Unassigned

Status

Tamarin
Garbage Collection (mmGC)
P3
normal
7 years ago
3 years ago

People

(Reporter: Simon Wilkinson, Unassigned)

Tracking

(Blocks: 2 bugs)

unspecified
Q3 12 - Dolores
Dependency tree / graph
Bug Flags:
flashplayer-qrb +

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

7 years ago
Created attachment 501398 [details] [diff] [review]
Initial Patch. MQ rev 181

Uniform, Tiered2 and Tiered4 are made thread-safe.
Tiered2 and Tiered4 are trivial. Uniform requires its expand operation be performed as a SafepointTask.

CacheT4 and DelayT4 are not thread-safe. Without a clever thread-safe caching scheme, it's probably not worth the overhead. (I don't have numbers or an implementation do back this up though)

Tiered4 is made the default for 64-bit builds instead of DelayT4.
(Reporter)

Updated

7 years ago
Attachment #501398 - Attachment is patch: true
Attachment #501398 - Attachment mime type: application/octet-stream → text/plain
(Reporter)

Updated

7 years ago
Blocks: 582770
(Reporter)

Updated

7 years ago
Attachment #501398 - Attachment is obsolete: true
(Reporter)

Comment 1

7 years ago
Created attachment 501484 [details] [diff] [review]
Latest patch. MQ rev 184


Cleaned up and fixed the Uniform build until bug 588878 lands.
(Reporter)

Comment 2

7 years ago
Created attachment 515824 [details] [diff] [review]
MQ rev 250
Attachment #501484 - Attachment is obsolete: true
(Reporter)

Comment 3

7 years ago
Comment on attachment 515824 [details] [diff] [review]
MQ rev 250

See http://asteam/hg/users/siwilkin/asymmGC-01 for an asymmGC patch queue
qfinished at rev 250 (against TR rev 5916).

See http://asteam.corp.adobe.com/hg/users/fklockii/tr-patch-queues for the
current queue
Attachment #515824 - Flags: review?(fklockii)
Performance results?  (Particularly for the 64-bit runtime variants?)
(Reporter)

Comment 5

7 years ago
Created attachment 521938 [details] [diff] [review]
Rebased. TR rev 6090. Patch queue rev 261
Attachment #515824 - Attachment is obsolete: true
Attachment #521938 - Flags: review?(fklockii)
Attachment #515824 - Flags: review?(fklockii)
(Reporter)

Comment 6

7 years ago
64-bit results are on the way

Updated

7 years ago
Blocks: 647918

Comment 7

7 years ago
Are the results available?
(Reporter)

Comment 8

7 years ago
(In reply to comment #7)
> Are the results available?

As posted on the asymmGC tracking bug (bug 582770), there is a spreadsheet being maintained here:
http://asteam.corp.adobe.com/builds/downloads/siwilkin/asym_gc_perf.xlsm

This contains performance results for every patch in the asymmGC queue for Android, Windows, Linux and Mac, for both 32 and 64-bit builds where appropriate.
Comment on attachment 521938 [details] [diff] [review]
Rebased. TR rev 6090. Patch queue rev 261

(I'm still a tiny bit worried about regressions due to falling back to Tiered4 rather than DelayT4.  But this can land and I can deal with that later if need be.)
Attachment #521938 - Flags: review?(fklockii) → review+

Comment 10

7 years ago
The following comment appears a couple of times:

    //FIXME: This critical section should be removed when the asymmGC-gcalloc
    // patch has been applied.

It's not clear exactly what patch is being referred to here, and we should make sure that the FIXME will get removed at the appropriate time.  By convention, a FIXME should include a bug number addressing the issue.  It should be sufficient to reference the bug number associated with the patch.
(Reporter)

Updated

7 years ago
Assignee: nobody → fklockii

Updated

7 years ago
Priority: -- → P3
Target Milestone: --- → Q1 12 - Brannan
(Reporter)

Comment 11

7 years ago
Created attachment 525553 [details] [diff] [review]
Fixed wmaddox's points. TR rev 6090. Patch queue rev 268
Attachment #521938 - Attachment is obsolete: true
Attachment #525553 - Flags: superreview?(lhansen)

Comment 12

6 years ago
Retargeting to Dolores.
Target Milestone: Q1 12 - Brannan → Q3 12 - Dolores

Updated

6 years ago
Assignee: fklockii → nobody

Updated

6 years ago
Flags: flashplayer-qrb+

Updated

6 years ago
Attachment #525553 - Flags: superreview?(lhansen)
You need to log in before you can comment on or make changes to this bug.