62337 - innerHTML misrepresents style attributes

Status: VERIFIED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Wolfgang Schwarz]

The innerHTML property of an element does not correctly display the HTML content 
of the element:

<div id="element1">
   <div id="element2" style="color:red">text in element2</div>
</div>

Calling alert(document.getElementById("element1").innerHTML) will now show:

<div id="element2" style="element2color: red; ">text in element2</div>

Two things are wrong with that:
- the element id reappears in the style value.
- white spaces and semicolons are inserted in the style value.

This happens with M0.6 on win98.

Comment 1

[Johnny Stenback (:jst)]

There's nothing wrong with adding the whitespace and the semicolon to the
attribute value since that's only a normalized version of the style rule, it
still has the exact same meaning. The fact that the id attribute value appears
in the style attribute seems weird and is wrong, could you attach a testcase to
this bug that demonstrates what you stated above? Thanks!

Comment 2

[Wolfgang Schwarz]

Attachment: testcase

Comment 3

[Johnny Stenback (:jst)]

Thanks for the testcase!

I found the problem, fixing it is a one liner in nsGenericHTMLElement.cpp

Index: html/content/src/nsGenericHTMLElement.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/content/src/nsGenericHTMLElement.cpp,v
retrieving revision 1.221
diff -u -r1.221 nsGenericHTMLElement.cpp
--- nsGenericHTMLElement.cpp    2000/11/27 07:54:37     1.221
+++ nsGenericHTMLElement.cpp    2000/12/09 02:36:58
@@ -1726,14 +1627,16 @@
 nsGenericHTMLElement::GetAttribute(PRInt32 aNameSpaceID, nsIAtom *aAttribute,
                                    nsAWritableString& aResult) const
 {
+  aResult.SetLength(0);
+
 #if 0

Note, line numbers may wary...

I'll land this fix with my content model cleanup landing that will hopefully
happen next week. If this isn't marked fixed in a week please remind me about it.

Comment 4

[Wolfgang Schwarz]

herewith I remind you. :)

Comment 5

[Johnny Stenback (:jst)]

Thanks! Unfortunately I wasn't able to get my changes in yet, hopefully this
week, feel free to remind me again in a week-or-so :-)

Comment 6

[djoham]

CC'ing self. Johnny, I'm seeing a problem that when I use innerHTML, the style
of the HTML element is completely ignored. For example if I use the following:

document.getElementById("hello").innerHTML = "<INPUT type=\"text\"
style=\"color: green\" value=\"foo2\">";

the color is completely ignored (along with every other style element). Will
landing your changes fix this or should I log another bug?

I'll upload my testcase so you can take a look at it as well.

Thanks

David

Comment 7

[djoham]

Attachment: example of innerHTML ignoring styles

Comment 8

[djoham]

drat, sorry for the spam. I'm using mozilla build 2001010306 on Linux 2.2.

Comment 9

[Johnny Stenback (:jst)]

The changes that included my fix for this landed a few weeks ago, marking FIXED.

djoham, the problem you found is unrelated to this bug, please open a new DOM
bug on that problem.

Comment 10

[Johnny Stenback (:jst)]

Really marking fixed this time.

Comment 11

[Hixie (not reading bugmail)]

Taking QA Contact on all open or unverified DOM Style bugs...

Comment 12

[Hixie (not reading bugmail)]

testcases appear to work now