623503 - Factor out MozMill content-tab helpers into a separate file

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch, v1

I'm going to need this for the about:support tests.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Looks good to me.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 501637 [details] [diff] [review]
patch, v1

>diff --git a/mail/test/mozmill/content-tabs/test-content-tab.js b/mail/test/mozmill/content-tabs/test-content-tab.js
>-var MODULE_REQUIRES = ['window-helpers'];
>+var MODULE_REQUIRES = ['window-helpers', 'content-tab-helpers'];
...
> var setupModule = function (module) {
>-  windowHelper = collector.getModule('window-helpers');
>-  mc = windowHelper.wait_for_existing_window("mail:3pane");
>-  windowHelper.installInto(module);
>-  windowHelper.augment_controller(mc);
>+  let fdh = collector.getModule('folder-display-helpers');
>+  fdh.installInto(module);
>+  let cth = collector.getModule('content-tab-helpers');
>+  cth.installInto(module);
> };

I think you should be removing window-helpers from MODULES_REQUIRES. I guess we don't need folder-display-helpers because that's required in content-tab-helpers?

>diff --git a/mail/test/mozmill/content-tabs/test-lwthemes.js b/mail/test/mozmill/content-tabs/test-lwthemes.js

>@@ -47,28 +47,25 @@ var MODULE_REQUIRES = ['window-helpers']

This needs updating.

r=Standard8 with those fixed.

Comment 3

[Rain [:rain1] (inactive)]

(In reply to comment #2)
> I think you should be removing window-helpers from MODULES_REQUIRES. I guess we
> don't need folder-display-helpers because that's required in
> content-tab-helpers?

Probably, but I fixed it anyway.

I've made two more changes: move the pageLoaded and pageLoading variable sets to inside the STATE_IS_NETWORK guards (to only care about the top-level request), and fix the copyright year in test-content-tab-helpers.js. I'm waiting for the tree to turn green to land.

Comment 4

[Rain [:rain1] (inactive)]

https://hg.mozilla.org/comm-central/rev/6f67325cc686